Skip to content
This repository was archived by the owner on May 15, 2024. It is now read-only.

Conversation

@jamesmontemagno
Copy link
Collaborator

Description of Change

Implement UWP navigation modes and also fix iOS navigation.

Added "none" mode.

Bugs Fixed

Provide links to issues here. Ensure that a GitHub issue was created for your feature or bug fix before sending PR.

API Changes

List all API changes here (or just put None), example:

Added:

  • enum - enum MapDirectionsMode.None { get; set; }

Behavioral Changes

Describe any non-bug related behavioral changes that may change how users app behaves when upgrading to this version of the codebase.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Updated documentation (see walkthrough)

Mrnikbobjeff and others added 2 commits August 3, 2018 07:37
* Implemented maps as mentioned in branch name issue. also fixed a spelling mistake

* Finished reset of fork

* Fixed ios maps transportation mode
@jamesmontemagno jamesmontemagno requested a review from Redth August 3, 2018 17:03
@dend
Copy link
Contributor

dend commented Aug 3, 2018

✅ Validation status: passed

File Status Preview URL Details
Samples/Samples/View/MapsPage.xaml ✅Succeeded
Samples/Samples/ViewModel/MapsViewModel.cs ✅Succeeded
Xamarin.Essentials/Maps/MapDirectionsMode.shared.cs ✅Succeeded
Xamarin.Essentials/Maps/MapLaunchOptions.shared.cs ✅Succeeded
Xamarin.Essentials/Maps/Maps.ios.cs ✅Succeeded
Xamarin.Essentials/Maps/Maps.uwp.cs ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-android.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-ios.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-uwp.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials.xml ✅Succeeded
docs/en/Xamarin.Essentials/MapDirectionsMode.xml ✅Succeeded
docs/en/Xamarin.Essentials/Maps.xml ✅Succeeded
docs/en/Xamarin.Essentials/MapsLaunchOptions.xml ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@Redth
Copy link
Member

Redth commented Aug 3, 2018

Should we do something similar on Android to handle directions mode?

https://developers.google.com/maps/documentation/urls/android-intents#launch_turn_by_turn_navigation

It looks like we could technically call the intent uri google.navigation: and add a mode=w to it. However this of course is more opinionated on which app it should use to launch navigation (though I wonder if other apps register themselves to handle that prefix and maybe this is ok).

@jamesmontemagno jamesmontemagno added the awaiting-review This PR needs to have a set of eyes on it label Aug 3, 2018
@jamesmontemagno jamesmontemagno added this to the 0.10.0-preview milestone Aug 3, 2018
@jamesmontemagno
Copy link
Collaborator Author

@Redth implemented!

@dend
Copy link
Contributor

dend commented Aug 3, 2018

✅ Validation status: passed

File Status Preview URL Details
Samples/Samples/View/MapsPage.xaml ✅Succeeded
Samples/Samples/ViewModel/MapsViewModel.cs ✅Succeeded
Xamarin.Essentials/Maps/MapDirectionsMode.shared.cs ✅Succeeded
Xamarin.Essentials/Maps/MapLaunchOptions.shared.cs ✅Succeeded
Xamarin.Essentials/Maps/Maps.android.cs ✅Succeeded
Xamarin.Essentials/Maps/Maps.ios.cs ✅Succeeded
Xamarin.Essentials/Maps/Maps.uwp.cs ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-android.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-ios.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-uwp.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials.xml ✅Succeeded
docs/en/Xamarin.Essentials/MapDirectionsMode.xml ✅Succeeded
docs/en/Xamarin.Essentials/Maps.xml ✅Succeeded
docs/en/Xamarin.Essentials/MapsLaunchOptions.xml ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@jamesmontemagno jamesmontemagno changed the title GH-440 Fix iOS Navigation & UWP Navigation too! GH-440 Fix iOS Navigation & UWP/Android Navigation too! Aug 8, 2018
@Redth Redth merged commit 555a589 into master Aug 14, 2018
@Redth Redth deleted the bug/issue-440 branch August 14, 2018 17:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

awaiting-review This PR needs to have a set of eyes on it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants