Skip to content
This repository was archived by the owner on May 15, 2024. It is now read-only.

Conversation

@ncarandini
Copy link
Contributor

@ncarandini ncarandini commented Jun 21, 2018

Description of Change

I've simply changed the order of the parameters in the call of the CalculateDistance(…).

Bugs Fixed

Now the CalculateDistance(Location locationStart, Location locationEnd, DistanceUnits units) returns correct values.

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests: not needed, it's a straightforward bug fix
  • Has samples: not needed
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Updated documentation: no documentation change needed

@dend
Copy link
Contributor

dend commented Jun 21, 2018

✅ Validation status: passed

File Status Preview URL Details
Xamarin.Essentials/Types/Location.shared.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@jamesmontemagno
Copy link
Collaborator

build

@ncarandini
Copy link
Contributor Author

ncarandini commented Jun 23, 2018

Hi @jamesmontemagno, is build related to the CI process or something that I have to do?

@dend
Copy link
Contributor

dend commented Jun 25, 2018

✅ Validation status: passed

File Status Preview URL Details
Xamarin.Essentials/Types/Location.shared.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@Redth Redth merged commit 7d41c50 into xamarin:master Jun 25, 2018
@Redth
Copy link
Member

Redth commented Jun 25, 2018

Thanks for this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants