fix(astro): invalid font url (#14440)

Author: florian-lefebvre

.changeset/cuddly-islands-cut.md

@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+Fixes a case where the URLs generated by the experimental Fonts API would be incorrect in dev

packages/astro/src/assets/fonts/implementations/url-proxy-hash-resolver.ts

@@ -22,9 +22,26 @@ export function createDevUrlProxyHashResolver({
 	return {
 		resolve(input) {
 			const { cssVariable, data } = input;
-			return [cssVariable.slice(2), data.weight, data.style, baseHashResolver.resolve(input)]
+			return [
+				cssVariable.slice(2),
+				formatWeight(data.weight),
+				data.style,
+				baseHashResolver.resolve(input),
+			]
 				.filter(Boolean)
 				.join('-');
 		},
 	};
 }
+
+function formatWeight(
+	weight: Parameters<UrlProxyHashResolver['resolve']>[0]['data']['weight'],
+): string | undefined {
+	if (Array.isArray(weight)) {
+		return weight.join('-');
+	}
+	if (typeof weight === 'number') {
+		return weight.toString();
+	}
+	return weight;
+}

packages/astro/test/units/assets/fonts/implementations.test.js

@@ -457,5 +457,23 @@ describe('fonts implementations', () => {
 			}),
 			'foo-400-italic-whatever.woff2',
 		);
+		assert.equal(
+			resolver.resolve({
+				cssVariable: '--foo',
+				data: { weight: '500', style: 'italic' },
+				originalUrl: 'whatever',
+				type: 'woff2',
+			}),
+			'foo-500-italic-whatever.woff2',
+		);
+		assert.equal(
+			resolver.resolve({
+				cssVariable: '--foo',
+				data: { weight: [100, 900], style: 'italic' },
+				originalUrl: 'whatever',
+				type: 'woff2',
+			}),
+			'foo-100-900-italic-whatever.woff2',
+		);
 	});
 });