Export logic of adding entry points to webpack config #782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The refactoring looks like a good idea to me so 👍 . |
Member
|
Thanks, I like the separating into more modules, that'll make it easier to write tests for it. Sorry for the delay, it was a very busy week at work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This is a refactoring and adds a new feature.
Did you add or update the
examples/?No
Summary
It adds a new static method
addDevServerEntrypoints()to the exports. This method could be reused in alternative implementations like the grunt plugin instead of copying the code.Does this PR introduce a breaking change?
no
Other information