fix: avoid unnecessary searching port #2648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2648 +/- ##
==========================================
+ Coverage 95.21% 95.26% +0.05%
==========================================
Files 30 30
Lines 1505 1501 -4
Branches 430 429 -1
==========================================
- Hits 1433 1430 -3
+ Misses 72 71 -1
Continue to review full report at Codecov.
|
anshumanv
approved these changes
Apr 21, 2021
rishabh3112
approved these changes
Apr 21, 2021
snitin315
approved these changes
Apr 21, 2021
jamesgeorge007
approved these changes
Apr 21, 2021
|
I think this PR may have caused a regression. See https://github.com/webpack/webpack-cli/issues/2696 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix/refactor
Did you add tests for your changes?
Will be added with
webpack-dev-server@betaIf relevant, did you update the documentation?
No need
Summary
we don't need to search free port before start webpack dev server, v4 do it automatically, so let's simplify it and avoid unnecessary code (also remove
dev.publicPath, this option doesn't exist in webpack dev server v3)Does this PR introduce a breaking change?
No
Other information
No