Skip to content

fix(modern-compiler): dispose redundant compilers #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 1, 2024
Merged

fix(modern-compiler): dispose redundant compilers #1245

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad5b193
fix(modern-compiler): dispose redundant compilers
hikiko4ern Oct 31, 2024
9db2543
test: added
alexander-akait Oct 31, 2024
6ad4ecb
test: fix
alexander-akait Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -768,6 +768,8 @@
webpackCompiler.hooks.shutdown.tap("sass-loader", () => {
compiler.dispose();
});
} else {
compiler.dispose();

Check warning on line 772 in src/utils.js

View check run for this annotation

Codecov / codecov/patch

src/utils.js#L771-L772 

Added lines #L771 - L772 were not covered by tests
Copy link
Member

@evenstensberg evenstensberg Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of if/elses deeply nested, but we can't return early in this scope, so it's okay.

}
}

Expand Down