Skip to content

Conversation

@rossbulat
Copy link
Contributor

No description provided.

@rossbulat rossbulat requested a review from Copilot June 5, 2025 11:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Enables TypeScript strict mode and updates code and dependencies to satisfy stricter type checks

  • Enabled "strict": true in tsconfig.base.json
  • Added type annotations, non-null assertions, and fallback logic to address new strict errors
  • Bumped @w3ux/types versions and added missing type dependencies

Reviewed Changes

Copilot reviewed 17 out of 18 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tsconfig.base.json Switched strict to true
library/utils/src/unit.ts Handled undefined cases in sortWithNull
library/utils/src/base.ts Added fallback array to simpleCamelCase and typed rmDecimals
library/types/src/extensions.ts Made extension non-optional (`ExtensionInterface
library/types/package.json Bumped version to 2.2.3
library/react-polkicon/src/utils.tsx Wrapped .find with fallback to satisfy return type
library/react-odometer/src/index.tsx Introduced RefObject typing for digit refs and odometerCurrent
library/react-connect-kit/package.json Updated @w3ux/types to ^2.2.3
library/observables-connect/src/extensions/reconnect.ts Added non-null assertions for extension usage
library/observables-connect/src/extensions/init.ts Added safe chaining for error.startsWith
library/observables-connect/src/extensions/enable.ts Asserted injectedWeb3 non-null and updated extension on reject
library/observables-connect/src/extensions/discover.ts Initialized injectedWeb3Interval as undefined
library/observables-connect/src/accounts/get.ts Added non-null assertion for extension.accounts.get
library/observables-connect/package.json Updated @w3ux/types to ^2.2.3
library/hooks/package.json Updated @w3ux/types to ^2.2.3
library/factories/package.json Updated @w3ux/types to ^2.2.3
builder/package.json Added missing @types/minimist
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

@rossbulat rossbulat merged commit 2c2c460 into main Jun 5, 2025
3 checks passed
This was referenced Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants