feat(refactor): Extension accounts observables & refactors, extensions re-write

[rossbulat]

This pull request introduces significant refactoring of the extension accounts observables and a comprehensive re-write of the extensions module. The primary objectives and changes include:

• Refactored Extension Accounts Observables: Improved the structure and management of observables related to extension accounts, enhancing performance and maintainability.
• Extensions Module Re-write: Overhauled the existing extensions module to streamline functionality, reduce redundancy, and align with current best practices.
• Codebase Simplification: Reduced the overall code complexity by removing approximately 932 lines of code and adding 736 lines, resulting in a net decrease of 196 lines.
• Improved Maintainability: The refactored codebase is now more modular and easier to navigate, facilitating future enhancements and debugging.

Impact

Backward Compatibility: Efforts have been made to maintain backward compatibility; however, thorough testing is recommended to ensure seamless integration.

Performance Enhancements: The refactoring is expected to yield performance improvements in handling extension accounts.

Testing

Comprehensive testing has been conducted to verify the stability and functionality of the changes. It is advisable for the QA team to perform additional tests to confirm that all features operate as intended.

Related Issues:

[List any related issues or link to relevant discussions, if applicable.]

Notes

Developers integrating this update should review the changes to understand the new structure and adjust their implementations accordingly.

Documentation has been updated to reflect the modifications.

[Copilot]

Copilot reviewed 9 out of 16 changed files in this pull request and generated 3 comments.

Files not reviewed (7)

• library/factories/package.json: Language not supported
• library/hooks/package.json: Language not supported
• library/observables-connect/package.json: Language not supported
• library/react-connect-kit/package.json: Language not supported
• library/types/package.json: Language not supported
• library/utils/package.json: Language not supported
• pnpm-lock.yaml: Language not supported

[Copilot]

Copilot reviewed 21 out of 25 changed files in this pull request and generated no comments.

Files not reviewed (4)

• library/factories/package.json: Language not supported
• library/hooks/package.json: Language not supported
• library/observables-connect/package.json: Language not supported
• library/react-connect-kit/package.json: Language not supported

Comments suppressed due to low confidence (1)

library/react-connect-kit/src/ExtensionAccountsProvider/index.tsx:171

• The function name 'handleExtensionAccountsUdpdate' appears to have a typo; consider renaming it to 'handleExtensionAccountsUpdate' to improve clarity.

      } = handleExtensionAccountsUdpdate(

[Copilot]

Copilot reviewed 30 out of 34 changed files in this pull request and generated 2 comments.

Files not reviewed (4)

• library/factories/package.json: Language not supported
• library/hooks/package.json: Language not supported
• library/observables-connect/package.json: Language not supported
• library/react-connect-kit/package.json: Language not supported

[Copilot]

Copilot reviewed 29 out of 33 changed files in this pull request and generated no comments.

Files not reviewed (4)

• library/factories/package.json: Language not supported
• library/hooks/package.json: Language not supported
• library/observables-connect/package.json: Language not supported
• library/react-connect-kit/package.json: Language not supported

Comments suppressed due to low confidence (3)

library/observables-connect/src/extensions/init.ts:38

• Ensure that 'error' is guaranteed to be a string before calling string methods like startsWith and substring to avoid potential runtime errors.

if (error.startsWith('Error')) {

library/observables-connect/src/extensions/discover.ts:42

• Ensure that the function 'handleCompleted' is defined or imported in this file so that the completion logic works as intended.

if (counter === maxChecks) { handleCompleted(false) }

library/observables-connect/src/accounts/util.ts:40

• [nitpick] Consider replacing the hardcoded string 'external' with a named constant to improve maintainability and clarity.

.filter(({ address }) => !_extensionAccounts.getValue().find((j) => j.address === address && j.source !== 'external'))