-
Notifications
You must be signed in to change notification settings - Fork 21
feat(refactor): Removes bignumber.js as utils dependency, remove obsolete utils, enhance unit utils
#130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bignumber.js as utils dependency.bignumber.js as utils dependency, remove obsolete utils
bignumber.js as utils dependency, remove obsolete utilsbignumber.js as utils dependency, remove obsolete utils, enhance unit units
bignumber.js as utils dependency, remove obsolete utils, enhance unit unitsbignumber.js as utils dependency, remove obsolete utils, enhance unit utils
2 tasks
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Breaking changes: Bumps
@w3ux/utilsmajor version.bignumber.jsas a w3ux dependency, and improves types support for the functions that were usingBigNumber.planckToUnitandunitToPlancknow allowBigInt | string | numberas their input value.planckToUnitreturns a string, whereasunitToPlanckreturns aBigInt. The prior returnsstringinstead ofnumberas there is no guarantee the resulting value will be a within the max supported value.minDecimalPlacesallowBigInt | string | numberas its input value, and retains commas if present in input.minDecimalPlaces.The following utils have been removed as a result of
BigNumber.jsbeing deprecated:greaterThanZero- syntax sugar over BigNumber.js syntax.isNotZero- syntax sugar over BigNumber.js syntax.evalUnits- unused in Polkadot Cloud apps.stringToBigNumber- no longer required.transformToBaseUnit- duplicate ofplanckToUnit.Docs: