Skip to content

Commit 5e6287d

Browse files
Change RtpHeaderExtension URI to numerical ID.
1 parent 230f64f commit 5e6287d

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

api-outline.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ interface RtpPacket {
3131

3232
interface RtpHeaderExtension {
3333
constructor(required RtpHeaderExtensionInit);
34-
readonly attribute DOMString uri;
34+
readonly attribute octet id;
3535
readonly attribute ArrayBuffer value;
3636
undefined copyValueTo(AllowSharedBufferSource destination);
3737
}
@@ -51,7 +51,7 @@ dictionary RtpPacketInit {
5151
}
5252

5353
dictionary RtpHeaderExtensionInit {
54-
required DOMString uri;
54+
required octet id;
5555
required AllowSharedBufferSource value;
5656
}
5757

explainer-use-case-1.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -52,14 +52,14 @@ rtpSendStream.onpacketizedrtp = () => {
5252
### Example 2: Send custom RTP header extension
5353

5454
```javascript
55-
// TODO: Negotiate headerExtensionCalculator.uri in SDP
55+
// TODO: Negotiate headerExtensionCalculator.id in SDP
5656
const [pc, rtpSender] = await customPeerConnectionWithRtpSender();
5757
const headerExtensionGenerator = new CustomHeaderExtensionGenerator();
5858
const rtpSendStream = await rtpSender.replaceSendStreams()[0];
5959
rtpSendStream.onpacketizedrtp = () => {
6060
for (const rtpPacket of rtpSendStream.readPacketizedRtp()) {
6161
rtpPacket.setHeaderExtension({
62-
uri: headerExtensionGenerator.uri,
62+
id: headerExtensionGenerator.id,
6363
value: headerExtensionGenerator.generate(rtpPacket),
6464
});
6565
rtpSendStream.sendRtp(rtpPacket)
@@ -70,14 +70,14 @@ rtpSendStream.onpacketizedrtp = () => {
7070
### Example 3: Receive custom RTP header extension
7171

7272
```javascript
73-
// TODO: Negotiate headerExtensionProcessor.uri in SDP
73+
// TODO: Negotiate headerExtensionProcessor.id in SDP
7474
const [pc, rtpReceiver] = await customPeerConnectionWithRtpReceiver();
7575
const headerExtensionProcessor = new CustomHeaderExtensionProcessor();
7676
const rtpReceiveStream = await videoRtpReceiver.replaceReceiveStreams()[0];
7777
rtpReceiveStream.onreceivedrtp = () => {
7878
for (const rtpPacket of rtpReceiveStream.readReceivedRtp()) {
7979
for (const headerExtension of rtpPacket.headerExtensions) {
80-
if (headerExtension.uri == headerExtensionProcessor.uri) {
80+
if (headerExtension.id == headerExtensionProcessor.id) {
8181
headerExtensionProcessor.process(headerExtension.value);
8282
}
8383
}
@@ -216,7 +216,7 @@ rtpReceiveStream.onrtpreceived = () => {
216216
### Example 10: Send custom FEC
217217

218218
```javascript
219-
// TODO: Negotiate headerExtensionCalculator.uri in SDP
219+
// TODO: Negotiate headerExtensionCalculator.id in SDP
220220
const [pc, rtpSender] = await customPeerConnectionWithRtpSender();
221221
const fecGenerator = new CustomFecGenerator();
222222
const rtpSendStream = await rtpSender.replaceSendStreams()[0];
@@ -233,7 +233,7 @@ rtpSendStream.onpacketizedrtp = () => {
233233
### Example 11: Receive custom FEC
234234

235235
```javascript
236-
// TODO: Negotiate headerExtensionProcessor.uri in SDP
236+
// TODO: Negotiate headerExtensionProcessor.id in SDP
237237
const [pc, rtpReceiver] = await customPeerConnectionWithRtpReceiver();
238238
const fecProcessor = new CustomFecProcessor();
239239
const rtpReceiveStream = await videoRtpReceiver.replaceReceiveStreams()[0];

0 commit comments

Comments
 (0)