Fix vue/require-prop-type-constructor

Author: armano2

lib/rules/require-prop-type-constructor.js

@@ -45,24 +45,24 @@ module.exports = {
       }
     }
 
-    const checkPropertyNode = (p) => {
-      if (isForbiddenType(p.value)) {
+    const checkPropertyNode = (key, node) => {
+      if (isForbiddenType(node)) {
         context.report({
-          node: p.value,
+          node: node,
           message,
           data: {
-            name: utils.getStaticPropertyName(p.key)
+            name: utils.getStaticPropertyName(key)
           },
-          fix: fix(p.value)
+          fix: fix(node)
         })
-      } else if (p.value.type === 'ArrayExpression') {
-        p.value.elements
+      } else if (node.type === 'ArrayExpression') {
+        node.elements
           .filter(prop => isForbiddenType(prop))
           .forEach(prop => context.report({
             node: prop,
             message,
             data: {
-              name: utils.getStaticPropertyName(p.key)
+              name: utils.getStaticPropertyName(key)
             },
             fix: fix(prop)
           }))
@@ -81,17 +81,18 @@ module.exports = {
 
       node.value.properties
         .forEach(p => {
-          if (isForbiddenType(p.value) || p.value.type === 'ArrayExpression') {
-            checkPropertyNode(p)
-          } else if (p.value.type === 'ObjectExpression') {
-            const typeProperty = p.value.properties.find(prop =>
+          const pValue = utils.unwrapTypes(p.value)
+          if (isForbiddenType(pValue) || pValue.type === 'ArrayExpression') {
+            checkPropertyNode(p.key, pValue)
+          } else if (pValue.type === 'ObjectExpression') {
+            const typeProperty = pValue.properties.find(prop =>
               prop.type === 'Property' &&
               prop.key.name === 'type'
             )
 
             if (!typeProperty) return
 
-            checkPropertyNode(typeProperty)
+            checkPropertyNode(p.key, utils.unwrapTypes(typeProperty.value))
           }
         })
     })

tests/lib/rules/no-side-effects-in-computed-properties.js

@@ -248,6 +248,24 @@ ruleTester.run('no-side-effects-in-computed-properties', rule, {
         line: 23,
         message: 'Unexpected side effect in "test4" computed property.'
       }]
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        export default Vue.extend({
+          computed: {
+            test1() : string {
+              return this.something.reverse()
+            }
+          }
+        });
+      `,
+      parserOptions,
+      errors: [{
+        line: 5,
+        message: 'Unexpected side effect in "test1" computed property.'
+      }],
+      parser: 'typescript-eslint-parser'
     }
   ]
 })

tests/lib/rules/require-prop-type-constructor.js

@@ -91,10 +91,10 @@ ruleTester.run('require-prop-type-constructor', rule, {
         message: 'The "anotherType" property should be a constructor.',
         line: 5
       }, {
-        message: 'The "type" property should be a constructor.',
+        message: 'The "extraProp" property should be a constructor.',
         line: 7
       }, {
-        message: 'The "type" property should be a constructor.',
+        message: 'The "lastProp" property should be a constructor.',
         line: 11
       }, {
         message: 'The "nullProp" property should be a constructor.',
@@ -136,6 +136,34 @@ ruleTester.run('require-prop-type-constructor', rule, {
         message: 'The "d" property should be a constructor.',
         line: 7
       }]
+    },
+    {
+      filename: 'SomeComponent.vue',
+      code: `
+      export default {
+        props: {
+          a: {
+            type: 'String',
+            default: 10
+          } as PropOptions<string>,
+        }
+      }
+      `,
+      output: `
+      export default {
+        props: {
+          a: {
+            type: String,
+            default: 10
+          } as PropOptions<string>,
+        }
+      }
+      `,
+      errors: [{
+        message: 'The "a" property should be a constructor.',
+        line: 5
+      }],
+      parser: 'typescript-eslint-parser'
     }
   ]
 })