Skip to content

Conversation

@LucasWilkinson
Copy link
Collaborator

FIX: #28400

Signed-off-by: Lucas Wilkinson <[email protected]>
Signed-off-by: Lucas Wilkinson <[email protected]>
@LucasWilkinson LucasWilkinson added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 10, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds conditional skips to context parallelism tests based on GPU compute capability, which is a good approach to handle hardware-specific features in CI. The logic for deepseek-ai/DeepSeek-V2-Lite-Chat seems correct. However, the condition for bigcode/gpt_bigcode-santacoder is overly restrictive and could prevent tests from running on future GPU architectures. I've provided a suggestion to make this more forward-compatible.

@robertgshaw2-redhat
Copy link
Collaborator

robertgshaw2-redhat commented Nov 10, 2025

Can you create a "good first issue" asking for someone to contribute a better error message if the attn backend is incompatible?

I know we have ongoing work to add more backends

LucasWilkinson and others added 2 commits November 10, 2025 09:38
Signed-off-by: Lucas Wilkinson <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Lucas Wilkinson <[email protected]>
@LucasWilkinson
Copy link
Collaborator Author

Can you create a "good first issue" asking for someone to contribute a better error message if the attn backend is incompatible?

I know we have ongoing work to add more backends

I made an issue (#28407) but Im scared we will only get a minor improvement in the error message for alot of complexity (basically maintaining an independent list backends that support DCP); i think it may be best to wait for #24794 which should be landing shortly

Signed-off-by: Lucas Wilkinson <[email protected]>
@robertgshaw2-redhat robertgshaw2-redhat enabled auto-merge (squash) November 10, 2025 22:42
@robertgshaw2-redhat
Copy link
Collaborator

shoot, didnt mean to hit that button 🤦

@robertgshaw2-redhat robertgshaw2-redhat merged commit 39029d5 into vllm-project:main Nov 11, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI Failure]: Nightly Failure B200 (Context Parallel)

2 participants