[BugFix] Reordering extend logic fix #27739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas Wilkinson <[email protected]>
Signed-off-by: Lucas Wilkinson <[email protected]>
5 tasks
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces important fixes to the batch reordering logic, correcting the definitions of 'extend' and 'prefill' requests and fixing how permutations are applied. The changes improve correctness. However, I've identified a more fundamental issue in the partitioning algorithm that could still lead to incorrect ordering in some scenarios. Additionally, a new test case appears to have an expected output that doesn't align with the implementation's logic, which could mask bugs. My review includes critical feedback on the partitioning algorithm and a high-severity comment on the test case discrepancy.
LucasWilkinson
added
the
ready
heheda12345
approved these changes
Oct 30, 2025
MatthewBonanni
pushed a commit
to MatthewBonanni/vllm
that referenced
this pull request
Oct 30, 2025
Signed-off-by: Lucas Wilkinson <[email protected]>
ilmarkov
pushed a commit
to neuralmagic/vllm
that referenced
this pull request
Nov 7, 2025
Signed-off-by: Lucas Wilkinson <[email protected]>
ZhengHongming888
pushed a commit
to ZhengHongming888/vllm
that referenced
this pull request
Nov 8, 2025
Signed-off-by: Lucas Wilkinson <[email protected]>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
Signed-off-by: Lucas Wilkinson <[email protected]>
eldarkurtic
pushed a commit
to eldarkurtic/vllm
that referenced
this pull request
Nov 12, 2025
Signed-off-by: Lucas Wilkinson <[email protected]> Signed-off-by: Eldar Kurtic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incorrect definition of extends in #27367, more extensive unit tests, fix reordering bug when multiple swaps are involved + light refactor.
Credit to @ganyi1996ppo for finding the issue