[Bugfix] Make get_mrope_input_positions instance methods

[DarkLight1337]

Purpose

Some methods were still defined as classmethods, contrary to the interface.

Follow up to #24172

Test Plan

Test Result

---

Essential Elements of an Effective PR Description Checklist

• The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
• The test plan, such as providing test command.
• The test results, such as pasting the results comparison before and after, or e2e results
• (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
• (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

[gemini-code-assist]

Code Review

This pull request correctly changes get_mrope_input_positions from a classmethod to an instance method across multiple models to align with the SupportsMRoPE interface. While reviewing, I noticed that the type hints for image_grid_thw in these methods do not match the interface, which expects them to be optional. The current implementations would raise an error if None is passed. I've added comments with high severity to correct the type hints and suggest adding None checks to prevent potential runtime errors.

[gemini-code-assist]

The get_mrope_input_positions method signature in the SupportsMRoPE interface specifies that image_grid_thw can be None. This implementation's type hint should be updated to reflect this by adding | None.

Additionally, the method body does not correctly handle the case where image_grid_thw or video_grid_thw are None. For example, image_grid_thw.tolist() at line 1430 will raise an AttributeError if image_grid_thw is None. Please add checks to handle None values at the beginning of the method, for instance by initializing them to an empty list.

Suggested change

	image_grid_thw: list[list[int]] | torch.Tensor,
	image_grid_thw: list[list[int]] | torch.Tensor | None,

[gemini-code-assist]

The get_mrope_input_positions method signature in the SupportsMRoPE interface specifies that image_grid_thw can be None. This implementation's type hint should be updated to reflect this by adding | None.

Additionally, the method body does not correctly handle the case where image_grid_thw or video_grid_thw are None. For example, image_grid_thw.tolist() at line 644 will raise an AttributeError if image_grid_thw is None. Please add checks to handle None values at the beginning of the method, for instance by initializing them to an empty list.

Suggested change

	image_grid_thw: list[list[int]] | torch.Tensor,
	image_grid_thw: list[list[int]] | torch.Tensor | None,

[gemini-code-assist]

The get_mrope_input_positions method signature in the SupportsMRoPE interface specifies that image_grid_thw can be None. This implementation's type hint should be updated to reflect this by adding | None.

Additionally, the method body does not correctly handle the case where image_grid_thw or video_grid_thw are None. For example, len(image_grid_thw) at line 641 will raise a TypeError if image_grid_thw is None. Please add checks to handle None values at the beginning of the method, for instance by initializing them to an empty list.

Suggested change

	image_grid_thw: list[list[int]] | torch.Tensor,
	image_grid_thw: list[list[int]] | torch.Tensor | None,

[gemini-code-assist]

The get_mrope_input_positions method signature in the SupportsMRoPE interface specifies that image_grid_thw can be None. This implementation's type hint should be updated to reflect this by adding | None.

Additionally, the method body does not correctly handle the case where image_grid_thw or video_grid_thw are None. For example, torch.tensor(image_grid_thw) at line 1035 will raise an error if image_grid_thw is None. Please add checks to handle None values at the beginning of the method, for instance by initializing them to an empty list or tensor.

Suggested change

	image_grid_thw: list[list[int]] | torch.Tensor,
	image_grid_thw: list[list[int]] | torch.Tensor | None,

[gemini-code-assist]

The get_mrope_input_positions method signature in the SupportsMRoPE interface specifies that image_grid_thw can be None. This implementation's type hint should be updated to reflect this by adding | None.

Additionally, the method body does not correctly handle the case where image_grid_thw or video_grid_thw are None. For example, indexing image_grid_thw at line 1128 will raise a TypeError if it is None. Please add checks to handle None values at the beginning of the method, for instance by initializing them to an empty list.

Suggested change

	image_grid_thw: list[list[int]] | torch.Tensor,
	image_grid_thw: list[list[int]] | torch.Tensor | None,

[gemini-code-assist]

The get_mrope_input_positions method signature in the SupportsMRoPE interface specifies that image_grid_thw can be None. This implementation's type hint should be updated to reflect this by adding | None.

Additionally, the method body does not correctly handle the case where image_grid_thw or video_grid_thw are None. For example, indexing image_grid_thw at line 1529 will raise a TypeError if it is None. Please add checks to handle None values at the beginning of the method, for instance by initializing them to an empty list.

Suggested change

	image_grid_thw: list[list[int]] | torch.Tensor,
	image_grid_thw: list[list[int]] | torch.Tensor | None,