Skip to content

Revert "[Bugfix] Limit profiling run sequence length by max_model_len (#14785) #14892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2025
Merged

Revert "[Bugfix] Limit profiling run sequence length by max_model_len (#14785) #14892

merged 1 commit into from
Mar 16, 2025

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Mar 16, 2025 •
edited by github-actions bot
Loading

This PR doesn't work on V1. Reverting for now.

cc @kylesayrs

@github-actions
Copy link

github-actions bot commented Mar 16, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@vllm-bot vllm-bot merged commit f6137ad into vllm-project:main Mar 16, 2025
9 of 10 checks passed
@DarkLight1337 DarkLight1337 deleted the revert-14785 branch March 16, 2025 16:19
DefTruth pushed a commit to DefTruth/vllm that referenced this pull request Mar 17, 2025
@DarkLight1337 @DefTruth
Revert "[Bugfix] Limit profiling run sequence length by max_model_len (…
c61ec83 
…vllm-project#14785) (vllm-project#14892)

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DefTruth <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@DarkLight1337 @lulmer
Revert "[Bugfix] Limit profiling run sequence length by max_model_len (…
c4f7468 
…vllm-project#14785) (vllm-project#14892)

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@DarkLight1337 @shreyankg
Revert "[Bugfix] Limit profiling run sequence length by max_model_len (…
f52e5df 
…vllm-project#14785) (vllm-project#14892)

Signed-off-by: DarkLight1337 <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@DarkLight1337
Revert "[Bugfix] Limit profiling run sequence length by max_model_len (…
d3b0a11 
…vllm-project#14785) (vllm-project#14892)

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DarkLight1337 @vllm-bot