Skip to content

[V1] Remove V0 fallback for mistral-tokenizer #14873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2025
Merged

[V1] Remove V0 fallback for mistral-tokenizer #14873

merged 1 commit into from
Mar 16, 2025

Conversation

@ywang96
Copy link
Member

@ywang96 ywang96 commented Mar 15, 2025

Discussed with @robertgshaw2-redhat offline that this is fine to remove now

@ywang96
remove
c459ce0 
Signed-off-by: Roger Wang <[email protected]>
@github-actions
Copy link

github-actions bot commented Mar 15, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@ywang96 ywang96 added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 16, 2025
@aarnphm aarnphm added this to the v0.8.0 milestone Mar 16, 2025
@simon-mo simon-mo merged commit b30c75d into main Mar 16, 2025
43 of 46 checks passed
@simon-mo simon-mo deleted the remove-mistral-fallback branch March 16, 2025 03:21
DefTruth pushed a commit to DefTruth/vllm that referenced this pull request Mar 17, 2025
@ywang96 @DefTruth
[V1] Remove V0 fallback for mistral-tokenizer (vllm-project#14873)
f2d5fe2 
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: DefTruth <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@ywang96 @lulmer
[V1] Remove V0 fallback for mistral-tokenizer (vllm-project#14873)
9803159 
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@ywang96 @shreyankg
[V1] Remove V0 fallback for mistral-tokenizer (vllm-project#14873)
392a326 
Signed-off-by: Roger Wang <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@ywang96
[V1] Remove V0 fallback for mistral-tokenizer (vllm-project#14873)
ce9a153 
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

v0.8.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ywang96 @DarkLight1337 @simon-mo @aarnphm