Skip to content

[Bugfix] Limit profiling run sequence length by max_model_len #14785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 16, 2025
Merged

[Bugfix] Limit profiling run sequence length by max_model_len #14785

merged 4 commits into from
Mar 16, 2025

Conversation

@kylesayrs
Copy link
Contributor

@kylesayrs kylesayrs commented Mar 14, 2025 •
edited by DarkLight1337
Loading

Purpose

  • Fix whisper offline inference example
  • Under specific conditions (short max_model_len and low max_num_seqs), the sequence length generated for the profiling run can be larger than the max model length

Changes

  • Add max_model_len cap to enc_dec and standard model runners

Testing

This example used to fail during profiling

  • python3 examples/offline_inference/audio_language.py --model whisper

@github-actions
Copy link

github-actions bot commented Mar 14, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Mar 14, 2025
DarkLight1337
DarkLight1337 reviewed Mar 14, 2025
View reviewed changes
DarkLight1337
DarkLight1337 reviewed Mar 14, 2025
View reviewed changes
vllm/worker/model_runner.py
for group_id in range(max_num_seqs):
seq_len = (max_num_batched_tokens // max_num_seqs +
(group_id < max_num_batched_tokens % max_num_seqs))
seq_len = min(seq_len, self.model_config.max_model_len)
Copy link
Member

@DarkLight1337 DarkLight1337 Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check other model runners as well

Copy link
Contributor Author

@kylesayrs kylesayrs Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not intimately familiar with the other runners, but I've replicated the cap on xpu

Copy link
Member

@DarkLight1337 DarkLight1337 Mar 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also openvino model runner

@kylesayrs
add back explicit model length
943b9ab 
Signed-off-by: Kyle Sayers <[email protected]>
@kylesayrs
cap xpu, add assertion error
2e05b45 
Signed-off-by: Kyle Sayers <[email protected]>
@kylesayrs
cap openvino
d40e9e9 
Signed-off-by: Kyle Sayers <[email protected]>
@DarkLight1337
Copy link
Member

DarkLight1337 commented Mar 16, 2025

LGTM now, thanks for your patience!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) March 16, 2025 03:51
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 16, 2025
@vllm-bot vllm-bot merged commit d30aa7e into vllm-project:main Mar 16, 2025
44 of 47 checks passed
@kylesayrs kylesayrs deleted the kylesayrs/cap-seq-len-profile-run branch March 16, 2025 15:55
@kylesayrs kylesayrs restored the kylesayrs/cap-seq-len-profile-run branch March 16, 2025 16:04
DarkLight1337 added a commit to DarkLight1337/vllm that referenced this pull request Mar 16, 2025
@DarkLight1337
Revert "[Bugfix] Limit profiling run sequence length by max_model_len (…
105289f 
…vllm-project#14785)"

This reverts commit d30aa7e.

Signed-off-by: DarkLight1337 <[email protected]>
vllm-bot pushed a commit that referenced this pull request Mar 16, 2025
@DarkLight1337
Revert "[Bugfix] Limit profiling run sequence length by max_model_len (…
f6137ad 
…#14785) (#14892)

Signed-off-by: DarkLight1337 <[email protected]>
DefTruth pushed a commit to DefTruth/vllm that referenced this pull request Mar 17, 2025
@kylesayrs @DefTruth
[Bugfix] Limit profiling run sequence length by max_model_len (vllm-p…
40e7f44 
…roject#14785)

Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: DefTruth <[email protected]>
DefTruth pushed a commit to DefTruth/vllm that referenced this pull request Mar 17, 2025
@DarkLight1337 @DefTruth
Revert "[Bugfix] Limit profiling run sequence length by max_model_len (…
c61ec83 
…vllm-project#14785) (vllm-project#14892)

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DefTruth <[email protected]>
@kylesayrs kylesayrs mentioned this pull request Mar 18, 2025
Closed
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@kylesayrs @lulmer
[Bugfix] Limit profiling run sequence length by max_model_len (vllm-p…
83b9fe5 
…roject#14785)

Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@DarkLight1337 @lulmer
Revert "[Bugfix] Limit profiling run sequence length by max_model_len (…
c4f7468 
…vllm-project#14785) (vllm-project#14892)

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@kylesayrs @shreyankg
[Bugfix] Limit profiling run sequence length by max_model_len (vllm-p…
e90d140 
…roject#14785)

Signed-off-by: Kyle Sayers <[email protected]>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@DarkLight1337 @shreyankg
Revert "[Bugfix] Limit profiling run sequence length by max_model_len (…
f52e5df 
…vllm-project#14785) (vllm-project#14892)

Signed-off-by: DarkLight1337 <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@kylesayrs
[Bugfix] Limit profiling run sequence length by max_model_len (vllm-p…
8d36589 
…roject#14785)

Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@DarkLight1337
Revert "[Bugfix] Limit profiling run sequence length by max_model_len (…
d3b0a11 
…vllm-project#14785) (vllm-project#14892)

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kylesayrs @DarkLight1337 @vllm-bot