[Frontend] Fix log message to use http vs https #14774
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
This log message specified `http://` unconditionally. It should use `https://` when SSL is in use. Closes vllm-project#14767 Signed-off-by: Russell Bryant <[email protected]>
russellb
force-pushed
the
server-url-https
branch
from
c358900 to
d026e22
Compare
|
CI passed on the previous commit so we can force-merge this once pre-commit passes |
Signed-off-by: Russell Bryant <[email protected]> Signed-off-by: Richard Liu <[email protected]>
Signed-off-by: Russell Bryant <[email protected]> Signed-off-by: Louis Ulmer <[email protected]>
Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: Russell Bryant <[email protected]> Signed-off-by: Mu Huai <[email protected]>
3 participants
This log message specified
http://unconditionally. It should usehttps://when SSL is in use.Closes #14767
Signed-off-by: Russell Bryant [email protected]