Skip to content

[VLM] Cleanup siglip legacy code and fix broken paligemma multimodal processor #14602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 11, 2025
Merged

[VLM] Cleanup siglip legacy code and fix broken paligemma multimodal processor #14602

merged 3 commits into from
Mar 11, 2025

Conversation

@Isotr0py
Copy link
Member

@Isotr0py Isotr0py commented Mar 11, 2025 •
edited by github-actions bot
Loading

No description provided.

Isotr0py added 2 commits March 10, 2025 23:13
@Isotr0py
cleanup siglip
bfee48c 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
fix paligemma
938314b 
Signed-off-by: Isotr0py <[email protected]>
@github-actions
Copy link

github-actions bot commented Mar 11, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@Isotr0py Isotr0py requested a review from DarkLight1337 March 11, 2025 07:53
DarkLight1337
DarkLight1337 approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup, I was planning on this but haven't had time to do it!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) March 11, 2025 07:57
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 11, 2025
@Isotr0py
remove assertion
3c2fe2b 
Signed-off-by: Isotr0py <[email protected]>
@DarkLight1337 DarkLight1337 merged commit 1477ffc into vllm-project:main Mar 11, 2025
32 checks passed
@Isotr0py Isotr0py deleted the siglip-cleanup branch March 11, 2025 11:35
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@Isotr0py @lulmer
[VLM] Cleanup siglip legacy code and fix broken paligemma multimodal …
d1197d3 
…processor (vllm-project#14602)

Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@Isotr0py @shreyankg
[VLM] Cleanup siglip legacy code and fix broken paligemma multimodal …
e92188f 
…processor (vllm-project#14602)

Signed-off-by: Isotr0py <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@Isotr0py
[VLM] Cleanup siglip legacy code and fix broken paligemma multimodal …
15084b9 
…processor (vllm-project#14602)

Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Isotr0py @DarkLight1337