Skip to content

Conversation

@bufferoverflow
Copy link
Contributor

@bufferoverflow bufferoverflow commented Feb 10, 2025

before:
INFO 02-10 07:39:31 launcher.py:29] Route: /v1/rerank, Methods: POST

after:
INFO 02-09 11:36:52 [launcher.py:29] Route: /v1/rerank, Methods: POST

⚒️ with ❤️ by @siemens

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@bufferoverflow
Copy link
Contributor Author

@russellb If seen you contributed to the logging area of vllm, could you maybe have a look at this?

@bufferoverflow bufferoverflow force-pushed the fix/logging-opening-square-bracket branch from ed901f0 to da01e1e Compare February 22, 2025 06:42
Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! lgtm.

I'll try to get someone to merge this.

@DarkLight1337
Copy link
Member

Sorry for forgetting about this! Can you fix the pre-commit errors?

cc @youkaichao in case the logging format is intentional

before:
`INFO 02-10 07:39:31 launcher.py:29] Route: /v1/rerank, Methods: POST`

after:
`INFO 02-09 11:36:52 [launcher.py:29] Route: /v1/rerank, Methods: POST`

Signed-off-by: Roger Meier <[email protected]>
@bufferoverflow bufferoverflow force-pushed the fix/logging-opening-square-bracket branch from da01e1e to e6d51e4 Compare February 24, 2025 04:19
@youkaichao
Copy link
Member

Sorry for forgetting about this! Can you fix the pre-commit errors?

cc @youkaichao in case the logging format is intentional

I think it should be a typo. not intentional

@bufferoverflow
Copy link
Contributor Author

@DarkLight1337 pre-commit fixed, but now the Lint and Deploy Charts / lint-and-deploy (pull_request) fails which is unrelated to this PR.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) February 24, 2025 07:00
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 24, 2025
@simon-mo simon-mo merged commit c0e3ecd into vllm-project:main Feb 24, 2025
53 of 56 checks passed
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants