-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
[Bugfix] fix(logging): add missing opening square bracket #13011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] fix(logging): add missing opening square bracket #13011
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
|
@russellb If seen you contributed to the logging area of vllm, could you maybe have a look at this? |
ed901f0 to
da01e1e
Compare
russellb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch! lgtm.
I'll try to get someone to merge this.
|
Sorry for forgetting about this! Can you fix the pre-commit errors? cc @youkaichao in case the logging format is intentional |
before: `INFO 02-10 07:39:31 launcher.py:29] Route: /v1/rerank, Methods: POST` after: `INFO 02-09 11:36:52 [launcher.py:29] Route: /v1/rerank, Methods: POST` Signed-off-by: Roger Meier <[email protected]>
da01e1e to
e6d51e4
Compare
I think it should be a typo. not intentional |
|
@DarkLight1337 pre-commit fixed, but now the Lint and Deploy Charts / lint-and-deploy (pull_request) fails which is unrelated to this PR. |
…ct#13011) Signed-off-by: Louis Ulmer <[email protected]>
before:
INFO 02-10 07:39:31 launcher.py:29] Route: /v1/rerank, Methods: POSTafter:
INFO 02-09 11:36:52 [launcher.py:29] Route: /v1/rerank, Methods: POST⚒️ with ❤️ by @siemens