Skip to content

Conversation

@wxsIcey
Copy link
Collaborator

@wxsIcey wxsIcey commented Oct 25, 2025

What this PR does / why we need it?

vllm-project/vllm@83f478b

Fix spec decode rejection sampler, caused by vllm-project/vllm#26060
Fix some import, caused by vllm-project/vllm#27374
Fix scheduler_config.send_delta_data, caused by #3719
Fix init_with_cudagraph_sizes, caused by vllm-project/vllm#26016
Fix vl modelof replacing PatchEmbed's conv3d to linear layer, caused by vllm-project/vllm#27418

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

CI passed with new added/existing test.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@wxsIcey wxsIcey marked this pull request as ready for review October 25, 2025 08:43
@wxsIcey wxsIcey added ready read for review ready-for-test start test by label for PR labels Oct 25, 2025
Signed-off-by: Icey <[email protected]>
@wxsIcey
Copy link
Collaborator Author

wxsIcey commented Oct 27, 2025

Here we first fix spec decoding, return logprobs for spec decoding can be a future work.

@wxsIcey
Copy link
Collaborator Author

wxsIcey commented Oct 27, 2025

test_embedding_aclgraph.py is skipped

Signed-off-by: Icey <[email protected]>
Signed-off-by: Icey <[email protected]>
Signed-off-by: Icey <[email protected]>
return max(layer_counts)


# Update cudagraph capture sizes for vllm config
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is maybe not correct. I'll look more

if vllm_version_is("0.11.0"):
if not model_config.is_multimodal_model and \
structured_outputs_config.backend == "auto" and \
not scheduler_config.send_delta_data and \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getattr(scheduler_config, "send_delta_data", False)

@wangxiyuan wangxiyuan merged commit a7450db into vllm-project:main Oct 28, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:core ready read for review ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants