-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat(coverage): autoUpdate to support percentage formatting
#8456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
4 tasks
22372ee to
c04057f
Compare
autoUpdate to support percentage format
autoUpdate to support percentage formatautoUpdate to support percentage formatting
AriPerkkio
requested changes
Aug 24, 2025
ce8a7d8 to
9cd0689
Compare
9cd0689 to
cdda8f0
Compare
AriPerkkio
approved these changes
Aug 24, 2025
Member
AriPerkkio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the feature! 💯
Contributor
Author
|
Thanks @AriPerkkio! |
sheremet-va
approved these changes
Aug 27, 2025
This was referenced Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #8424
Description
I've found that when I have the boolean
autoUpdateflag enabled and run coverage reports on the same code multiple times, the coverage amounts vary but up to 0.03%. This means code will arbitrarily fail to pass the coverage requirements. Also I don't really care about my coverage percentage being accurate down to two decimal places, which is how V8 reports them.To address this, I've update the
autoUpdateflag to accept either a boolean or a function. If it's a boolean it will keep working as it did before. If it's a function, that function will run on each coverage percentage returned by the engine and return the result, which should be a number or undefined.So now you can do something like...
Now when you run
test:coverageor whatever your coverage script is, your coverage thresholds will come back rounded down to the nearest whole number.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.