Skip to content

Commit 7558b7e

Browse files
authored
fix(no-standalone-expect): Add it.for/test.for chains (#800)
* feat: add 'it.for' and 'test.for' to ValidVitestFnCallChains * test: add tests
1 parent 18c6f38 commit 7558b7e

File tree

3 files changed

+129
-1
lines changed

3 files changed

+129
-1
lines changed

scripts/chain-permutations.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ const data = [
2121
first: ['extend'],
2222
conditions: ['skipIf', 'runIf'],
2323
methods: ['skip', 'only', 'concurrent', 'sequential', 'todo', 'fails'],
24-
last: ['each'],
24+
last: ['each', 'for'],
2525
},
2626
{
2727
names: ['bench'],

src/utils/valid-vitest-fn-call-chains.ts

Lines changed: 120 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ export const ValidVitestFnCallChains = new Set([
1414
'it.skipIf',
1515
'it.runIf',
1616
'it.each',
17+
'it.for',
1718
'it.skip.only',
1819
'it.skip.concurrent',
1920
'it.skip.sequential',
@@ -68,11 +69,20 @@ export const ValidVitestFnCallChains = new Set([
6869
'it.sequential.each',
6970
'it.todo.each',
7071
'it.fails.each',
72+
'it.skip.for',
73+
'it.only.for',
74+
'it.concurrent.for',
75+
'it.sequential.for',
76+
'it.todo.for',
77+
'it.fails.for',
7178
'it.extend.skipIf',
7279
'it.extend.runIf',
7380
'it.extend.each',
81+
'it.extend.for',
7482
'it.skipIf.each',
83+
'it.skipIf.for',
7584
'it.runIf.each',
85+
'it.runIf.for',
7686
'it.skip.only.concurrent',
7787
'it.skip.only.sequential',
7888
'it.skip.only.todo',
@@ -313,6 +323,36 @@ export const ValidVitestFnCallChains = new Set([
313323
'it.fails.concurrent.each',
314324
'it.fails.sequential.each',
315325
'it.fails.todo.each',
326+
'it.skip.only.for',
327+
'it.skip.concurrent.for',
328+
'it.skip.sequential.for',
329+
'it.skip.todo.for',
330+
'it.skip.fails.for',
331+
'it.only.skip.for',
332+
'it.only.concurrent.for',
333+
'it.only.sequential.for',
334+
'it.only.todo.for',
335+
'it.only.fails.for',
336+
'it.concurrent.skip.for',
337+
'it.concurrent.only.for',
338+
'it.concurrent.sequential.for',
339+
'it.concurrent.todo.for',
340+
'it.concurrent.fails.for',
341+
'it.sequential.skip.for',
342+
'it.sequential.only.for',
343+
'it.sequential.concurrent.for',
344+
'it.sequential.todo.for',
345+
'it.sequential.fails.for',
346+
'it.todo.skip.for',
347+
'it.todo.only.for',
348+
'it.todo.concurrent.for',
349+
'it.todo.sequential.for',
350+
'it.todo.fails.for',
351+
'it.fails.skip.for',
352+
'it.fails.only.for',
353+
'it.fails.concurrent.for',
354+
'it.fails.sequential.for',
355+
'it.fails.todo.for',
316356
'it.extend.skipIf.skip',
317357
'it.extend.skipIf.only',
318358
'it.extend.skipIf.concurrent',
@@ -331,20 +371,40 @@ export const ValidVitestFnCallChains = new Set([
331371
'it.extend.sequential.each',
332372
'it.extend.todo.each',
333373
'it.extend.fails.each',
374+
'it.extend.skip.for',
375+
'it.extend.only.for',
376+
'it.extend.concurrent.for',
377+
'it.extend.sequential.for',
378+
'it.extend.todo.for',
379+
'it.extend.fails.for',
334380
'it.skipIf.skip.each',
335381
'it.skipIf.only.each',
336382
'it.skipIf.concurrent.each',
337383
'it.skipIf.sequential.each',
338384
'it.skipIf.todo.each',
339385
'it.skipIf.fails.each',
386+
'it.skipIf.skip.for',
387+
'it.skipIf.only.for',
388+
'it.skipIf.concurrent.for',
389+
'it.skipIf.sequential.for',
390+
'it.skipIf.todo.for',
391+
'it.skipIf.fails.for',
340392
'it.runIf.skip.each',
341393
'it.runIf.only.each',
342394
'it.runIf.concurrent.each',
343395
'it.runIf.sequential.each',
344396
'it.runIf.todo.each',
345397
'it.runIf.fails.each',
398+
'it.runIf.skip.for',
399+
'it.runIf.only.for',
400+
'it.runIf.concurrent.for',
401+
'it.runIf.sequential.for',
402+
'it.runIf.todo.for',
403+
'it.runIf.fails.for',
346404
'it.extend.skipIf.each',
405+
'it.extend.skipIf.for',
347406
'it.extend.runIf.each',
407+
'it.extend.runIf.for',
348408
'test',
349409
'test.skip',
350410
'test.only',
@@ -356,6 +416,7 @@ export const ValidVitestFnCallChains = new Set([
356416
'test.skipIf',
357417
'test.runIf',
358418
'test.each',
419+
'test.for',
359420
'test.skip.only',
360421
'test.skip.concurrent',
361422
'test.skip.sequential',
@@ -410,11 +471,20 @@ export const ValidVitestFnCallChains = new Set([
410471
'test.sequential.each',
411472
'test.todo.each',
412473
'test.fails.each',
474+
'test.skip.for',
475+
'test.only.for',
476+
'test.concurrent.for',
477+
'test.sequential.for',
478+
'test.todo.for',
479+
'test.fails.for',
413480
'test.extend.skipIf',
414481
'test.extend.runIf',
415482
'test.extend.each',
483+
'test.extend.for',
416484
'test.skipIf.each',
485+
'test.skipIf.for',
417486
'test.runIf.each',
487+
'test.runIf.for',
418488
'test.skip.only.concurrent',
419489
'test.skip.only.sequential',
420490
'test.skip.only.todo',
@@ -655,6 +725,36 @@ export const ValidVitestFnCallChains = new Set([
655725
'test.fails.concurrent.each',
656726
'test.fails.sequential.each',
657727
'test.fails.todo.each',
728+
'test.skip.only.for',
729+
'test.skip.concurrent.for',
730+
'test.skip.sequential.for',
731+
'test.skip.todo.for',
732+
'test.skip.fails.for',
733+
'test.only.skip.for',
734+
'test.only.concurrent.for',
735+
'test.only.sequential.for',
736+
'test.only.todo.for',
737+
'test.only.fails.for',
738+
'test.concurrent.skip.for',
739+
'test.concurrent.only.for',
740+
'test.concurrent.sequential.for',
741+
'test.concurrent.todo.for',
742+
'test.concurrent.fails.for',
743+
'test.sequential.skip.for',
744+
'test.sequential.only.for',
745+
'test.sequential.concurrent.for',
746+
'test.sequential.todo.for',
747+
'test.sequential.fails.for',
748+
'test.todo.skip.for',
749+
'test.todo.only.for',
750+
'test.todo.concurrent.for',
751+
'test.todo.sequential.for',
752+
'test.todo.fails.for',
753+
'test.fails.skip.for',
754+
'test.fails.only.for',
755+
'test.fails.concurrent.for',
756+
'test.fails.sequential.for',
757+
'test.fails.todo.for',
658758
'test.extend.skipIf.skip',
659759
'test.extend.skipIf.only',
660760
'test.extend.skipIf.concurrent',
@@ -673,20 +773,40 @@ export const ValidVitestFnCallChains = new Set([
673773
'test.extend.sequential.each',
674774
'test.extend.todo.each',
675775
'test.extend.fails.each',
776+
'test.extend.skip.for',
777+
'test.extend.only.for',
778+
'test.extend.concurrent.for',
779+
'test.extend.sequential.for',
780+
'test.extend.todo.for',
781+
'test.extend.fails.for',
676782
'test.skipIf.skip.each',
677783
'test.skipIf.only.each',
678784
'test.skipIf.concurrent.each',
679785
'test.skipIf.sequential.each',
680786
'test.skipIf.todo.each',
681787
'test.skipIf.fails.each',
788+
'test.skipIf.skip.for',
789+
'test.skipIf.only.for',
790+
'test.skipIf.concurrent.for',
791+
'test.skipIf.sequential.for',
792+
'test.skipIf.todo.for',
793+
'test.skipIf.fails.for',
682794
'test.runIf.skip.each',
683795
'test.runIf.only.each',
684796
'test.runIf.concurrent.each',
685797
'test.runIf.sequential.each',
686798
'test.runIf.todo.each',
687799
'test.runIf.fails.each',
800+
'test.runIf.skip.for',
801+
'test.runIf.only.for',
802+
'test.runIf.concurrent.for',
803+
'test.runIf.sequential.for',
804+
'test.runIf.todo.for',
805+
'test.runIf.fails.for',
688806
'test.extend.skipIf.each',
807+
'test.extend.skipIf.for',
689808
'test.extend.runIf.each',
809+
'test.extend.runIf.for',
690810
'bench',
691811
'bench.skip',
692812
'bench.only',

tests/no-standalone-expect.test.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,14 @@ ruleTester.run(RULE_NAME, rule, {
2525
'{}',
2626
'it.each([1, true])("trues", value => { expect(value).toBe(true); });',
2727
'it.each([1, true])("trues", value => { expect(value).toBe(true); }); it("an it", () => { expect(1).toBe(1) });',
28+
`
29+
it.for(["a", "b"])("test", (value, { expect }) => {
30+
expect(value).toBe(true)
31+
})
32+
test.for(["a", "b"])("test", (value, { expect }) => {
33+
expect(value).toBe(true)
34+
})
35+
`,
2836
],
2937
invalid: [
3038
{

0 commit comments

Comments
 (0)