fix: keep ids for virtual modules as-is (#20808)

Co-authored-by: btea <[email protected]>

Author: sapphi-red

packages/vite/src/node/server/pluginContainer.ts

@@ -462,7 +462,7 @@ class EnvironmentPluginContainer<Env extends Environment = Environment> {
     }
 
     if (id) {
-      partial.id = isExternalUrl(id) ? id : normalizePath(id)
+      partial.id = isExternalUrl(id) || id[0] === '\0' ? id : normalizePath(id)
       return partial as PartialResolvedId
     } else {
       return null

playground/resolve/__tests__/resolve.spec.ts

@@ -163,6 +163,10 @@ test('plugin resolved custom virtual file', async () => {
   expect(await page.textContent('.custom-virtual')).toMatch('[success]')
 })
 
+test('virtual file with URL scheme should not be rewritten (#20803)', async () => {
+  expect(await page.textContent('.virtual-url-scheme')).toMatch('[success]')
+})
+
 test('resolve inline package', async () => {
   expect(await page.textContent('.inline-pkg')).toMatch('[success]')
 })

playground/resolve/index.html

@@ -158,6 +158,9 @@ <h2>Plugin resolved virtual file (#9036)</h2>
 <h2>Plugin resolved custom virtual file</h2>
 <p class="custom-virtual"></p>
 
+<h2>Virtual file with URL scheme</h2>
+<p class="virtual-url-scheme"></p>
+
 <h2>Inline package</h2>
 <p class="inline-pkg"></p>
 
@@ -394,6 +397,9 @@ <h2>utf8-bom-package</h2>
   import { msg as customVirtualMsg } from '@custom-virtual-file'
   text('.custom-virtual', customVirtualMsg)
 
+  import { msg as virtualUrlSchemeMsg } from 'virtual-with-scheme'
+  text('.virtual-url-scheme', virtualUrlSchemeMsg)
+
   import { msg as inlineMsg } from './inline-package'
   text('.inline-pkg', inlineMsg)
 

playground/resolve/vite.config.js

@@ -10,6 +10,9 @@ const virtualId9036 = '\0' + virtualFile9036
 
 const customVirtualFile = '@custom-virtual-file'
 
+const virtualFileWithScheme = 'virtual-with-scheme'
+const virtualIdWithScheme = '\0https://example.com/virtual.js'
+
 const generatedContentVirtualFile = '@generated-content-virtual-file'
 const generatedContentImports = [
   {
@@ -77,6 +80,19 @@ export default defineConfig({
         }
       },
     },
+    {
+      name: 'virtual-url-scheme-test',
+      resolveId(id) {
+        if (id === virtualFileWithScheme) {
+          return virtualIdWithScheme
+        }
+      },
+      load(id) {
+        if (id === virtualIdWithScheme) {
+          return `export const msg = "[success] from virtual file with URL scheme"`
+        }
+      },
+    },
     {
       name: 'generated-content',
       resolveId(id) {