fix: better invalidation message when an export is added & fix HMR for export of nullish values

Author: ArnaudBarre

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 - Disable Fast Refresh based on `config.server.hmr === false` instead of `process.env.TEST`
 - Warn when plugin is in WebContainers (see [#118](https://github.com/vitejs/vite-plugin-react-swc/issues/118))
+- Better invalidation message when an export is added & fix HMR for export of nullish values ([#143](https://github.com/vitejs/vite-plugin-react-swc/issues/143))
 
 ## 3.3.2
 

playground/hmr/__tests__/hmr.spec.ts

@@ -46,7 +46,7 @@ test("HMR invalidate", async ({ page }) => {
     'React!";\nexport const useless = 3;',
   ]);
   await waitForLogs(
-    "[vite] invalidate /src/TitleWithExport.tsx: Could not Fast Refresh. Learn more at https://github.com/vitejs/vite-plugin-react-swc#consistent-components-exports",
+    "[vite] invalidate /src/TitleWithExport.tsx: Could not Fast Refresh (new export)",
     "[vite] hot updated: /src/App.tsx",
   );
 

src/refresh-runtime.js

@@ -587,17 +587,19 @@ export function validateRefreshBoundaryAndEnqueueUpdate(
   prevExports,
   nextExports,
 ) {
-  if (!predicateOnExport(prevExports, (key) => !!nextExports[key])) {
+  if (!predicateOnExport(prevExports, (key) => key in nextExports)) {
     return "Could not Fast Refresh (export removed)";
   }
+  if (!predicateOnExport(nextExports, (key) => key in prevExports)) {
+    return "Could not Fast Refresh (new export)";
+  }
 
   let hasExports = false;
   const allExportsAreComponentsOrUnchanged = predicateOnExport(
     nextExports,
     (key, value) => {
       hasExports = true;
       if (isLikelyComponentType(value)) return true;
-      if (!prevExports[key]) return false;
       return prevExports[key] === nextExports[key];
     },
   );