Skip to content

Update React from 14898b6a9 to e373190fa #63685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Update React from 14898b6a9 to e373190fa #63685

wants to merge 2 commits into from

Conversation

@gnoff
Copy link
Contributor

@gnoff gnoff commented Mar 25, 2024 •
edited by padmaia
Loading

Update React from 14898b6a9 to e373190fa

Closes NEXT-2923

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Mar 25, 2024
@socket-security
Copy link

socket-security bot commented Mar 25, 2024 •
edited
Loading

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

gnoff and others added 2 commits March 25, 2024 14:19
@gnoff
Update React from 14898b6a9 to e373190fa
1a2ce1f 
- facebook/react#28596
- facebook/react#28625
- facebook/react#28616
- facebook/react#28491
- facebook/react#28583
- facebook/react#28427
- facebook/react#28613
- facebook/react#28599
- facebook/react#28611
- facebook/react#28610
- facebook/react#28606
- facebook/react#28598
- facebook/react#28549
- facebook/react#28557
- facebook/react#28467
- facebook/react#28591
- facebook/react#28459
- facebook/react#28590
- facebook/react#28564
- facebook/react#28582
- facebook/react#28579
- facebook/react#28578
- facebook/react#28521
- facebook/react#28550
- facebook/react#28576
- facebook/react#28577
- facebook/react#28571
- facebook/react#28572
- facebook/react#28560
- facebook/react#28569
- facebook/react#28573
- facebook/react#28546
- facebook/react#28568
- facebook/react#28562
- facebook/react#28566
- facebook/react#28565
- facebook/react#28559
- facebook/react#28508
- facebook/react#20432
- facebook/react#28555
- facebook/react#24730
- facebook/react#28472
- facebook/react#27991
- facebook/react#28514
- facebook/react#28548
- facebook/react#28526
- facebook/react#28515
- facebook/react#28533
- facebook/react#28532
- facebook/react#28531
- facebook/react#28407
- facebook/react#28522
- facebook/react#28538
- facebook/react#28509
- facebook/react#28534
- facebook/react#28527
- facebook/react#28528
- facebook/react#28519
- facebook/react#28411
- facebook/react#28520
- facebook/react#28518
- facebook/react#28493
- facebook/react#28504
- facebook/react#28499
- facebook/react#28501
- facebook/react#28496
- facebook/react#28471
- facebook/react#28351
- facebook/react#28486
- facebook/react#28490
- facebook/react#28488
- facebook/react#28468
- facebook/react#28321
- facebook/react#28477
- facebook/react#28479
- facebook/react#28480
- facebook/react#28478
- facebook/react#28464
- facebook/react#28475
- facebook/react#28456
- facebook/react#28319
- facebook/react#28345
- facebook/react#28337
- facebook/react#28335
- facebook/react#28466
- facebook/react#28462
- facebook/react#28322
- facebook/react#28444
- facebook/react#28448
- facebook/react#28449
- facebook/react#28446
- facebook/react#28447
- facebook/react#24580
@ztanner @gnoff
test fixes
84df8ad
@ijjk
Copy link
Member

ijjk commented Mar 25, 2024 •
edited
Loading

Failing test suites

Commit: 84df8ad

pnpm test-dev test/e2e/app-dir/rsc-basic/rsc-basic.test.ts (PPR)

  • app dir - rsc basics > should be able to navigate between rsc routes
  • app dir - rsc basics > should not use bundled react for pages with app
  • app dir - rsc basics > should use canary react for app
  • app dir - rsc basics > should be able to call legacy react-dom/server APIs in client components
  • app dir - rsc basics > react@experimental > should opt into the react@experimental when enabling ppr
  • app dir - rsc basics > react@experimental > should opt into the react@experimental when enabling taint
Expand output

● app dir - rsc basics › should be able to navigate between rsc routes

request.allHeaders: Target page, context or browser has been closed

  145 |           page.on('request', (request) => {
  146 |             requestsCount++
> 147 |             return request.allHeaders().then((headers) => {
      |                            ^
  148 |               if (
  149 |                 headers['RSC'.toLowerCase()] === '1' &&
  150 |                 // Prefetches also include `RSC`

  at Page.allHeaders (e2e/app-dir/rsc-basic/rsc-basic.test.ts:147:28)

● app dir - rsc basics › should not use bundled react for pages with app

expect(received).toMatch(expected)

Expected substring: "-experimental-"
Received string:    ""

  494 |
  495 |       ssrAppReactVersions.forEach((version) =>
> 496 |         expect(version).toMatch(bundledReactVersionPattern)
      |                         ^
  497 |       )
  498 |
  499 |       const browser = await next.browser('/pages-react')

  at toMatch (e2e/app-dir/rsc-basic/rsc-basic.test.ts:496:25)
      at Array.forEach (<anonymous>)
  at Object.forEach (e2e/app-dir/rsc-basic/rsc-basic.test.ts:495:27)

● app dir - rsc basics › should use canary react for app

expect(received).toMatch(expected)

Expected substring: "-experimental-"
Received string:    ""

  535 |
  536 |       ssrPagesReactVersions.forEach((version) => {
> 537 |         expect(version).toMatch(bundledReactVersionPattern)
      |                         ^
  538 |       })
  539 |
  540 |       const browser = await next.browser('/app-react')

  at toMatch (e2e/app-dir/rsc-basic/rsc-basic.test.ts:537:25)
      at Array.forEach (<anonymous>)
  at Object.forEach (e2e/app-dir/rsc-basic/rsc-basic.test.ts:536:29)

● app dir - rsc basics › should be able to call legacy react-dom/server APIs in client components

expect(received).toBe(expected) // Object.is equality

Expected: "<div class=\"react-static-markup\">React Static Markup</div>"
Received: ""

  557 |       const $ = await next.render$('/app-react')
  558 |       const content = $('#markup').text()
> 559 |       expect(content).toBe(
      |                       ^
  560 |         '<div class="react-static-markup">React Static Markup</div>'
  561 |       )
  562 |

  at Object.toBe (e2e/app-dir/rsc-basic/rsc-basic.test.ts:559:23)

● app dir - rsc basics › react@experimental › should opt into the react@experimental when enabling ppr

expect(received).toMatch(expected)

Expected substring: "-experimental-"
Received string:    ""

  668 |
  669 |           ssrPagesReactVersions.forEach((version) => {
> 670 |             expect(version).toMatch('-experimental-')
      |                             ^
  671 |           })
  672 |
  673 |           const browser = await next.browser('/app-react')

  at toMatch (e2e/app-dir/rsc-basic/rsc-basic.test.ts:670:29)
      at Array.forEach (<anonymous>)
  at forEach (e2e/app-dir/rsc-basic/rsc-basic.test.ts:669:33)

● app dir - rsc basics › react@experimental › should opt into the react@experimental when enabling taint

expect(received).toMatch(expected)

Expected substring: "-experimental-"
Received string:    ""

  668 |
  669 |           ssrPagesReactVersions.forEach((version) => {
> 670 |             expect(version).toMatch('-experimental-')
      |                             ^
  671 |           })
  672 |
  673 |           const browser = await next.browser('/app-react')

  at toMatch (e2e/app-dir/rsc-basic/rsc-basic.test.ts:670:29)
      at Array.forEach (<anonymous>)
  at forEach (e2e/app-dir/rsc-basic/rsc-basic.test.ts:669:33)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev test/development/acceptance-app/ReactRefreshLogBox.test.ts

  • ReactRefreshLogBox app default > boundaries
Expand output

● ReactRefreshLogBox app default › boundaries

page.waitForSelector: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('[data-nextjs-toast]')

  421 |     return this.chain(() => {
  422 |       return page
> 423 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  424 |         .then(async (el) => {
  425 |           // it seems selenium waits longer and tests rely on this behavior
  426 |           // so we wait for the load event fire before returning

  at waitForSelector (lib/browsers/playwright.ts:423:10)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Mar 25, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary gnoff/next.js update-react Change
buildDuration 14s 14.1s ⚠️ +155ms
buildDurationCached 8.5s 6.2s N/A
nodeModulesSize 198 MB 199 MB ⚠️ +488 kB
nextStartRea..uration (ms) 407ms 406ms N/A
Client Bundles (main, webpack) Overall increase ⚠️
vercel/next.js canary gnoff/next.js update-react Change
2453-HASH.js gzip 30.8 kB 31.1 kB ⚠️ +267 B
3304.HASH.js gzip 181 B 181 B ✓
3f784ff6-HASH.js gzip 53.7 kB 53.5 kB N/A
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 242 B 241 B N/A
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 76.2 kB 76.5 kB ⚠️ +267 B
Legacy Client Bundles (polyfills)
vercel/next.js canary gnoff/next.js update-react Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary gnoff/next.js update-react Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B ✓
amp-HASH.js gzip 505 B 505 B ✓
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B ✓
head-HASH.js gzip 352 B 352 B ✓
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.21 kB 4.21 kB ✓
index-HASH.js gzip 259 B 259 B ✓
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 6.57 kB 6.57 kB ✓
Client Build Manifests
vercel/next.js canary gnoff/next.js update-react Change
_buildManifest.js gzip 481 B 484 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary gnoff/next.js update-react Change
index.html gzip 529 B 529 B ✓
link.html gzip 541 B 541 B ✓
withRouter.html gzip 523 B 523 B ✓
Overall change 1.59 kB 1.59 kB ✓
Edge SSR bundle Size
vercel/next.js canary gnoff/next.js update-react Change
edge-ssr.js gzip 95.3 kB 95.3 kB N/A
page.js gzip 3.04 kB 3.04 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary gnoff/next.js update-react Change
middleware-b..fest.js gzip 624 B 624 B ✓
middleware-r..fest.js gzip 151 B 151 B ✓
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B ✓
Overall change 1.61 kB 1.61 kB ✓
Next Runtimes Overall increase ⚠️
vercel/next.js canary gnoff/next.js update-react Change
app-page-exp...dev.js gzip 170 kB 170 kB N/A
app-page-exp..prod.js gzip 96.8 kB 97.5 kB ⚠️ +721 B
app-page-tur..prod.js gzip 98.5 kB 99 kB ⚠️ +454 B
app-page-tur..prod.js gzip 92.8 kB 93.3 kB ⚠️ +535 B
app-page.run...dev.js gzip 144 kB 156 kB ⚠️ +11.9 kB
app-page.run..prod.js gzip 91.3 kB 92 kB ⚠️ +763 B
app-route-ex...dev.js gzip 21.4 kB 21.2 kB N/A
app-route-ex..prod.js gzip 15.1 kB 15.1 kB N/A
app-route-tu..prod.js gzip 15.1 kB 15.1 kB N/A
app-route-tu..prod.js gzip 14.8 kB 14.8 kB N/A
app-route.ru...dev.js gzip 21 kB 21 kB N/A
app-route.ru..prod.js gzip 14.8 kB 14.8 kB N/A
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB ✓
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB ✓
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB ✓
pages-turbo...prod.js gzip 22.5 kB 22.5 kB ✓
pages.runtim...dev.js gzip 23.1 kB 23.1 kB ✓
pages.runtim..prod.js gzip 22.4 kB 22.4 kB ✓
server.runti..prod.js gzip 50.9 kB 50.9 kB ✓
Overall change 671 kB 685 kB ⚠️ +14.4 kB
build cache Overall increase ⚠️
vercel/next.js canary gnoff/next.js update-react Change
0.pack gzip 1.57 MB 1.56 MB N/A
index.pack gzip 106 kB 106 kB ⚠️ +142 B
Overall change 106 kB 106 kB ⚠️ +142 B
Diff details
Diff for middleware.js

Diff too large to display

Diff for 2453-HASH.js

Diff too large to display

Diff for 3f784ff6-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js 
failed to diff
Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js 
failed to diff
Diff for app-page.runtime.prod.js

Diff too large to display

Diff for app-route-ex..ntime.dev.js

Diff too large to display

Diff for app-route-ex..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route.runtime.dev.js

Diff too large to display

Diff for app-route.ru..time.prod.js

Diff too large to display

Commit: 84df8ad

@gnoff gnoff marked this pull request as draft March 26, 2024 15:01
@gnoff gnoff closed this Aug 20, 2024
@gnoff gnoff deleted the update-react branch August 20, 2024 20:50
@github-actions github-actions bot added the locked label Sep 4, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

@feedthejim feedthejim Awaiting requested review from feedthejim

@ztanner ztanner Awaiting requested review from ztanner

@wyattjoh wyattjoh Awaiting requested review from wyattjoh

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. locked tests type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gnoff @ijjk @balazsorban44 @ztanner