Skip to content

with-google-analytics: replace the GA_TRACKING_ID string by a environment variable #21817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 16, 2021
Merged

with-google-analytics: replace the GA_TRACKING_ID string by a environment variable #21817

merged 2 commits into from
Feb 16, 2021

Conversation

@Segolene-Alquier
Copy link
Contributor

@Segolene-Alquier Segolene-Alquier commented Feb 3, 2021 •
edited by leerob
Loading

Following this issue:

  • We just replaced the GA_TRACKING_ID string value with a environment variable
  • added a .env.local.example file to the with-google-analytics repo

Closes #21817.

@ijjk ijjk added the examples Issue was opened via the examples template. label Feb 3, 2021
@leerob
Copy link
Contributor

leerob commented Feb 16, 2021

Thank you so much!

@leerob leerob merged commit e917687 into vercel:canary Feb 16, 2021
This was referenced Mar 5, 2021
Closed
Merged
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Merged
Closed
Merged
Closed
Closed
This was referenced Mar 8, 2021
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
This was referenced Mar 15, 2021
Closed
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

1 more reviewer

@leerob leerob leerob approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

examples Issue was opened via the examples template.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Segolene-Alquier @leerob @ijjk