Skip to content

Commit c5159f6

Browse files
committed
Stop ignoring reveal errors
Should be gone so let's guard against new ones sneaking in
1 parent 3610f63 commit c5159f6

File tree

1 file changed

+5
-70
lines changed

1 file changed

+5
-70
lines changed

test/e2e/app-dir/errors/index.test.ts

Lines changed: 5 additions & 70 deletions
Original file line numberDiff line numberDiff line change
@@ -18,20 +18,7 @@ describe('app-dir - errors', () => {
1818
const browser = await next.browser('/client-component', {
1919
beforePageLoad: (page) => {
2020
page.on('pageerror', (error: unknown) => {
21-
if (
22-
error !== null &&
23-
typeof error === 'object' &&
24-
'message' in error &&
25-
typeof error.message === 'string' &&
26-
error.message.includes(
27-
"Cannot read properties of null (reading 'removeChild')"
28-
)
29-
) {
30-
// unactionable and just noise until we fix https://github.com/facebook/react/pull/33531
31-
// TODO: Don't ignore this error once the underlying issue is fixed.
32-
} else {
33-
pageErrors.push(error)
34-
}
21+
pageErrors.push(error)
3522
})
3623
},
3724
})
@@ -57,20 +44,7 @@ describe('app-dir - errors', () => {
5744
const browser = await next.browser('/server-component', {
5845
beforePageLoad: (page) => {
5946
page.on('pageerror', (error: unknown) => {
60-
if (
61-
error !== null &&
62-
typeof error === 'object' &&
63-
'message' in error &&
64-
typeof error.message === 'string' &&
65-
error.message.includes(
66-
"Cannot read properties of null (reading 'removeChild')"
67-
)
68-
) {
69-
// unactionable and just noise until we fix https://github.com/facebook/react/pull/33531
70-
// TODO: Don't ignore this error once the underlying issue is fixed.
71-
} else {
72-
pageErrors.push(error)
73-
}
47+
pageErrors.push(error)
7448
})
7549
},
7650
})
@@ -193,20 +167,7 @@ describe('app-dir - errors', () => {
193167
const browser = await next.browser('/global-error-boundary/client', {
194168
beforePageLoad: (page) => {
195169
page.on('pageerror', (error: unknown) => {
196-
if (
197-
error !== null &&
198-
typeof error === 'object' &&
199-
'message' in error &&
200-
typeof error.message === 'string' &&
201-
error.message.includes(
202-
"Cannot read properties of null (reading 'removeChild')"
203-
)
204-
) {
205-
// unactionable and just noise until we fix https://github.com/facebook/react/pull/33531
206-
// TODO: Don't ignore this error once the underlying issue is fixed.
207-
} else {
208-
pageErrors.push(error)
209-
}
170+
pageErrors.push(error)
210171
})
211172
},
212173
})
@@ -246,20 +207,7 @@ describe('app-dir - errors', () => {
246207
const browser = await next.browser('/global-error-boundary/server', {
247208
beforePageLoad: (page) => {
248209
page.on('pageerror', (error: unknown) => {
249-
if (
250-
error !== null &&
251-
typeof error === 'object' &&
252-
'message' in error &&
253-
typeof error.message === 'string' &&
254-
error.message.includes(
255-
"Cannot read properties of null (reading 'removeChild')"
256-
)
257-
) {
258-
// unactionable and just noise until we fix https://github.com/facebook/react/pull/33531
259-
// TODO: Don't ignore this error once the underlying issue is fixed.
260-
} else {
261-
pageErrors.push(error)
262-
}
210+
pageErrors.push(error)
263211
})
264212
},
265213
})
@@ -332,20 +280,7 @@ describe('app-dir - errors', () => {
332280
await next.browser('/ssr-error-client-component', {
333281
beforePageLoad: (page) => {
334282
page.on('pageerror', (error: unknown) => {
335-
if (
336-
error !== null &&
337-
typeof error === 'object' &&
338-
'message' in error &&
339-
typeof error.message === 'string' &&
340-
error.message.includes(
341-
"Cannot read properties of null (reading 'removeChild')"
342-
)
343-
) {
344-
// unactionable and just noise until we fix https://github.com/facebook/react/pull/33531
345-
// TODO: Don't ignore this error once the underlying issue is fixed.
346-
} else {
347-
pageErrors.push(error)
348-
}
283+
pageErrors.push(error)
349284
})
350285
},
351286
})

0 commit comments

Comments
 (0)