test fixes

ztanner · gnoff · commit 84df8adb8e52 · 2024-03-25T14:23:42.000-07:00
diff --git a/packages/next/src/client/app-index.tsx b/packages/next/src/client/app-index.tsx
@@ -19,7 +19,10 @@ import { HMR_ACTIONS_SENT_TO_BROWSER } from '../server/dev/hot-reloader-types'
 // Since React doesn't call onerror for errors caught in error boundaries.
 const origConsoleError = window.console.error
 window.console.error = (...args) => {
-  if (isNextRouterError(args[0])) {
+  // in dev, the actual error is the second argument.
+  const error = process.env.NODE_ENV === 'development' ? args[1] : args[0]
+
+  if (isNextRouterError(error)) {
     return
   }
   origConsoleError.apply(window.console, args)
diff --git a/test/development/acceptance-app/hydration-error.test.ts b/test/development/acceptance-app/hydration-error.test.ts
@@ -570,7 +570,7 @@ describe('Error overlay for hydration errors', () => {
 
     const warning = await session.getRedboxDescriptionWarning()
     expect(warning).toContain(
-      'In HTML, <script> cannot be a child of <html>.\nThis will cause a hydration error.'
+      `Cannot render a sync or defer <script> outside the main document without knowing its order. Try adding async="" or moving it into the root <head> tag.`
     )
 
     await cleanup()

Original file line number	Diff line number	Diff line change
`@@ -570,7 +570,7 @@ describe('Error overlay for hydration errors', () => {`
`570`	`570`
`571`	`571`	`const warning = await session.getRedboxDescriptionWarning()`
`572`	`572`	`expect(warning).toContain(`
`573`		`- 'In HTML, <script> cannot be a child of <html>.\nThis will cause a hydration error.'`
	`573`	+ `Cannot render a sync or defer <script> outside the main document without knowing its order. Try adding async="" or moving it into the root <head> tag.`
`574`	`574`	`)`
`575`	`575`
`576`	`576`	`await cleanup()`