chore(ruff) Automated fixes for Python 3.9 + ruff 0.8.4

Fixed 9 errors:
- src/libvcs/_internal/query_list.py:
    1 × RUF052 (used-dummy-variable)
- src/libvcs/cmd/git.py:
    2 × PLC1802 (len-test)
- src/libvcs/sync/svn.py:
    5 × RUF052 (used-dummy-variable)
    1 × RUF039 (unraw-re-pattern)

ruff check . --select ALL --fix --unsafe-fixes --preview --show-fixes --ignore T201 --ignore PT014 --ignore RUF100; ruff format .;

Author: tony

src/libvcs/_internal/query_list.py

@@ -526,19 +526,19 @@ def filter_lookup(obj: t.Any) -> bool:
             return True
 
         if callable(matcher):
-            _filter = matcher
+            filter_ = matcher
         elif matcher is not None:
 
             def val_match(obj: t.Union[str, list[t.Any], T]) -> bool:
                 if isinstance(matcher, list):
                     return obj in matcher
                 return bool(obj == matcher)
 
-            _filter = val_match
+            filter_ = val_match
         else:
-            _filter = filter_lookup
+            filter_ = filter_lookup
 
-        return self.__class__(k for k in self if _filter(k))
+        return self.__class__(k for k in self if filter_(k))
 
     def get(
         self,

src/libvcs/cmd/git.py

@@ -2033,7 +2033,7 @@ def rev_list(
                 "rev-list",
                 *local_flags,
                 *required_flags,
-                *(["--", *path_flags] if len(path_flags) else []),
+                *(["--", *path_flags] if path_flags else []),
             ],
             check_returncode=check_returncode,
             log_in_real_time=log_in_real_time,
@@ -2156,7 +2156,7 @@ def show_ref(
             [
                 "show-ref",
                 *local_flags,
-                *(["--", *pattern_flags] if len(pattern_flags) else []),
+                *(["--", *pattern_flags] if pattern_flags else []),
             ],
             check_returncode=check_returncode,
         )

src/libvcs/sync/svn.py

@@ -104,9 +104,9 @@ def get_revision_file(self, location: str) -> int:
         """Return revision for a file."""
         current_rev = self.cmd.info(location)
 
-        _INI_RE = re.compile(r"^([^:]+):\s+(\S.*)$", re.MULTILINE)
+        INI_RE = re.compile(r"^([^:]+):\s+(\S.*)$", re.MULTILINE)
 
-        info_list = _INI_RE.findall(current_rev)
+        info_list = INI_RE.findall(current_rev)
         return int(dict(info_list)["Revision"])
 
     def get_revision(self, location: Optional[str] = None) -> int:
@@ -165,10 +165,10 @@ def update_repo(
 
     @classmethod
     def _get_svn_url_rev(cls, location: str) -> tuple[Optional[str], int]:
-        _svn_xml_url_re = re.compile('url="([^"]+)"')
-        _svn_rev_re = re.compile(r'committed-rev="(\d+)"')
-        _svn_info_xml_rev_re = re.compile(r'\s*revision="(\d+)"')
-        _svn_info_xml_url_re = re.compile(r"<url>(.*)</url>")
+        svn_xml_url_re = re.compile(r'url="([^"]+)"')
+        svn_rev_re = re.compile(r'committed-rev="(\d+)"')
+        svn_info_xml_rev_re = re.compile(r'\s*revision="(\d+)"')
+        svn_info_xml_url_re = re.compile(r"<url>(.*)</url>")
 
         entries_path = pathlib.Path(location) / ".svn" / "entries"
         if entries_path.exists():
@@ -184,11 +184,11 @@ def _get_svn_url_rev(cls, location: str) -> tuple[Optional[str], int]:
             url = entries[0][3]
             revs = [int(d[9]) for d in entries if len(d) > 9 and d[9]] + [0]
         elif data.startswith("<?xml"):
-            match = _svn_xml_url_re.search(data)
+            match = svn_xml_url_re.search(data)
             if not match:
                 raise SvnUrlRevFormattingError(data=data)
             url = match.group(1)  # get repository URL
-            revs = [int(m.group(1)) for m in _svn_rev_re.finditer(data)] + [0]
+            revs = [int(m.group(1)) for m in svn_rev_re.finditer(data)] + [0]
         else:
             try:
                 # Note that using get_remote_call_options is not necessary here
@@ -200,10 +200,10 @@ def _get_svn_url_rev(cls, location: str) -> tuple[Optional[str], int]:
                     target=pathlib.Path(location),
                     xml=True,
                 )
-                match = _svn_info_xml_url_re.search(xml)
+                match = svn_info_xml_url_re.search(xml)
                 assert match is not None
                 url = match.group(1)
-                revs = [int(m.group(1)) for m in _svn_info_xml_rev_re.finditer(xml)]
+                revs = [int(m.group(1)) for m in svn_info_xml_rev_re.finditer(xml)]
             except Exception:
                 url, revs = None, []