project_openldap: check status.name instead of status_id PK #850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonLeary42
changed the title
simonLeary42
force-pushed
the
project-sync-status-prettier
branch
from
7f288a4 to
5c08b72
Compare
Contributor
|
old method had no benefit, this improves things |
simonLeary42
force-pushed
the
project-sync-status-prettier
branch
from
5c08b72 to
adcf6a7
Compare
Signed-off-by: Simon Leary <[email protected]>
simonLeary42
force-pushed
the
project-sync-status-prettier
branch
from
adcf6a7 to
7c9b662
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
comparing integer primary keys is more confusing than comparing string names, and I don't see it adding any benefit.