tests: fix sanitizer test. #32045
Merged
tests: fix sanitizer test. #32045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johann-S
approved these changes
Nov 2, 2020
The test template does not include a `script` tag so the test always returned true.
XhmikosR
force-pushed
the
main-xmr-sanitize-test
branch
from
9988ecc to
5857d7e
Compare
XhmikosR
added a commit
that referenced
this pull request
Nov 2, 2020
XhmikosR
added a commit
that referenced
this pull request
Nov 3, 2020
XhmikosR
added a commit
that referenced
this pull request
Nov 3, 2020
XhmikosR
added a commit
that referenced
this pull request
Nov 4, 2020
XhmikosR
added a commit
to mitchellfyi/bootstrap
that referenced
this pull request
Nov 5, 2020
tests: fix sanitizer test. The test template does not include a `script` tag so the test always returned true.
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test template does not include a
scripttag so the test always returned true.I need to check if the same issue is present in v4-dev. EDIT: it's present in v4-dev too, I'll backport it in #32035 after this one lands.
Requires #32043