Fix Dart Sass & Ruby Sass compatibility #29755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysds
approved these changes
Nov 27, 2019
Contributor
ysds
left a comment
ysds
left a comment
There was a problem hiding this comment.
@MartijnCuppens LGTM.
The #{$value1 "+" $value2} and #{$value1 "-" $value2} is another solution, but either is fine.
Member
Author
|
The minus isn't causing any issues if I'm not mistaken? Edit: I've tested this, it's not causing any issues |
MartijnCuppens
changed the title
Contributor
|
Yep, there is no problem with the My point is for reduce the code complexity by using the same format to plus and minus. |
XhmikosR
pushed a commit
that referenced
this pull request
Nov 28, 2019
XhmikosR
pushed a commit
that referenced
this pull request
Nov 28, 2019
This was referenced Dec 7, 2019
This was referenced Feb 5, 2020
This was referenced Feb 23, 2020
This was referenced Mar 4, 2020
This was referenced Mar 27, 2020
This was referenced Apr 4, 2020
Merged
This was referenced Apr 11, 2020
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29743, also works with ruby-sass: https://www.sassmeister.com/gist/ff625639f5c4e126d121c853d93f3025
Ping @XhmikosR @ysds