Skip to content

performance fix #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

performance fix #470

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion init/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,9 @@ static int __init set_init_arg(char *param, char *val,

repair_env_string(param, val, unused, NULL);

for (i = 0; argv_init[i]; i++) {
i = 0;
while(argv_init[i]){
Copy link

@siyiwolf siyiwolf Sep 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change while

Copy link

@zwang001 zwang001 Jan 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any special gain?

Copy link

@kalman5 kalman5 Jul 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also on first iteration i = 1 not 0 as it is with the for

i++;
Copy link

@sugar700 sugar700 Sep 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This skips i = 0, I believe.

if (i == MAX_INIT_ARGS) {
panic_later = "init";
panic_param = param;
Expand Down