Fix parse_cache_header signature change
#767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@timholy can you take a look at this to unbreak revise? |
|
This is my bad, I apologize! |
Collaborator
|
Not your fault. There's a structural issue in our process that this wasn't noticed - we'll need to fix that. |
fredrikekre
added a commit
that referenced
this pull request
Nov 14, 2023
This patch restores the filtering of non-src files that was lost in #767. After JuliaLang/julia#49866, `Base.parse_cache_header` returns both the non-filtered and filtered list instead of doing filtering internally based on the `srcfiles_only::Bool` keyword argument. There is a test for this failure mode that fails on Revise master branch and passes with this patch (see https://github.com/timholy/Revise.jl/blob/1059181bed06387e9fbcea137dce28a80c5c45d9/test/runtests.jl#L3070-L3080).
KristofferC
pushed a commit
that referenced
this pull request
Nov 14, 2023
* Restore filtering of non-src files This patch restores the filtering of non-src files that was lost in #767. After JuliaLang/julia#49866, `Base.parse_cache_header` returns both the non-filtered and filtered list instead of doing filtering internally based on the `srcfiles_only::Bool` keyword argument. There is a test for this failure mode that fails on Revise master branch and passes with this patch (see https://github.com/timholy/Revise.jl/blob/1059181bed06387e9fbcea137dce28a80c5c45d9/test/runtests.jl#L3070-L3080). * Set version to 3.5.9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base.parse_cache_headersremoved its keywordsrcfiles_onlyin JuliaLang/julia#49866, which makes Revise non-functional in nightly.There are a bunch of other test failures, and I'm not sure I understand the internals enough to address them, but I could identify least two sources (there are probably more):
LoadErrorseems to now (sometimes?) hold aMeta.ParseErrorvalue for its.errorfield, breaking a few tests which expect aStringinstead. A bunch of related error messages seem to have changed too.Pkg(the associated(::PkgData).info.filesis empty, probably that's because of that), breaking related tests.Anyway, we can probably merge this fix and worry about other failures on
nightlylater, such thatReviseworks again on nightly. Or if anyone wants to address nightly failures in a wider swath, that works for me too.