Skip to content

Commit 4e33ff7

Browse files
Marvin H?usermdkinney
authored andcommitted
QuarkSocPkg/QNCSmmDispatcher: Fix use after free issue #2
As part of commit 5f82e02, ActiveRecordInDb was introduced as a copy of RecordInDb as latter may be freed by the callback function. This commit replaces an access of RecordInDb after the callback function has been executed with an access to ActiveRecordInDb. Cc: Michael D Kinney <[email protected]> Cc: Kelly Steele <[email protected]> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marvin Haeuser <[email protected]> Reviewed-by: Michael D Kinney <[email protected]>
1 parent 6619cf3 commit 4e33ff7

File tree

1 file changed

+2
-2
lines changed
  • QuarkSocPkg/QuarkNorthCluster/Smm/DxeSmm/QncSmmDispatcher

1 file changed

+2
-2
lines changed

QuarkSocPkg/QuarkNorthCluster/Smm/DxeSmm/QncSmmDispatcher/QNCSmmCore.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
This driver is responsible for the registration of child drivers
33
and the abstraction of the QNC SMI sources.
44
5-
Copyright (c) 2013-2016 Intel Corporation.
5+
Copyright (c) 2013-2017 Intel Corporation.
66
77
This program and the accompanying materials
88
are licensed and made available under the terms and conditions of the BSD License
@@ -758,7 +758,7 @@ QNCSmmCoreDispatcher (
758758
}
759759
}
760760

761-
if (RecordInDb->ClearSource == NULL) {
761+
if (ActiveRecordInDb.ClearSource == NULL) {
762762
//
763763
// Clear the SMI associated w/ the source using the default function
764764
//

0 commit comments

Comments
 (0)