chore: jsdom15 and enable AngularNoNgAttributesSnapshotSerializer by default #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtho
added
dependencies
Collaborator
|
I think we should add a comment somewhere to remind ourselves to remove jest env jsdom 15 once jest 25 is out. |
Collaborator
Author
|
Will v15 be default from jest v25 on? Can you add a reference to that? Couldn't find anything in the jest repo. Thanks! |
Collaborator
|
Here you go |
wtho
force-pushed
the
chore/jsdom15-enable-serializer
branch
from
cefe9b9 to
3684c04
Compare
Collaborator
Author
|
Adding a simple issue is a good way keep it in mind #325 |
thymikee
approved these changes
Oct 18, 2019
namely * update default jsdom enviroment to v15 * enable AngularNoNgAttributesSnapshotSerializer by default * use better reference of astTransformers (always in preset instead of relative) to avoid user confusion in README
wtho
force-pushed
the
chore/jsdom15-enable-serializer
branch
from
3684c04 to
9751527
Compare
Collaborator
Author
|
force-push: rebase master branch to fix conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relative) to avoid user confusion in README