Skip to content

Commit d3e899b

Browse files
authored
fix: remove peer dep jest-environment-jsdom (#3333)
Since Jest has validation for `jsdom` option, it's possible for us to remove `jest-environment-jsdom` from peer dep + we don't actually use this dep in src code Fixes #3331
1 parent 0a54887 commit d3e899b

File tree

5 files changed

+3
-5
lines changed

5 files changed

+3
-5
lines changed

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@
6464
"@angular/platform-browser": ">=18.0.0 <21.0.0",
6565
"@angular/platform-browser-dynamic": ">=18.0.0 <21.0.0",
6666
"jest": "^30.0.0",
67-
"jest-environment-jsdom": "^30.0.0",
6867
"jsdom": ">=26.0.0",
6968
"typescript": ">=5.5"
7069
},

website/docs/getting-started/installation.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import TabItem from '@theme/TabItem';
1111
You can install `jest-preset-angular` and dependencies all at once with one of the following commands.
1212

1313
```bash npm2yarn
14-
npm install -D jest jest-preset-angular @types/jest
14+
npm install -D jest jest-preset-angular @types/jest jest-environment-jsdom jsdom
1515
```
1616

1717
### Configuration

website/versioned_docs/version-14.x/getting-started/installation.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import TabItem from '@theme/TabItem';
1111
You can install `jest-preset-angular` and dependencies all at once with one of the following commands.
1212

1313
```bash npm2yarn
14-
npm install -D jest jest-preset-angular @types/jest
14+
npm install -D jest jest-preset-angular @types/jest jest-environment-jsdom jsdom
1515
```
1616

1717
### Configuration

website/versioned_docs/version-15.0/getting-started/installation.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import TabItem from '@theme/TabItem';
1111
You can install `jest-preset-angular` and dependencies all at once with one of the following commands.
1212

1313
```bash npm2yarn
14-
npm install -D jest jest-preset-angular @types/jest
14+
npm install -D jest jest-preset-angular @types/jest jest-environment-jsdom jsdom
1515
```
1616

1717
### Configuration

yarn.lock

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8942,7 +8942,6 @@ __metadata:
89428942
"@angular/platform-browser": ">=18.0.0 <21.0.0"
89438943
"@angular/platform-browser-dynamic": ">=18.0.0 <21.0.0"
89448944
jest: ^30.0.0
8945-
jest-environment-jsdom: ^30.0.0
89468945
jsdom: ">=26.0.0"
89478946
typescript: ">=5.5"
89488947
dependenciesMeta:

0 commit comments

Comments
 (0)