From 0c007cf1f17841a04d141ee001e1c00fbd272b1d Mon Sep 17 00:00:00 2001 From: Alfi Maulana Date: Sun, 17 Dec 2023 14:38:16 +0700 Subject: [PATCH 1/3] build: rename executable to `generate_sequence` --- CMakeLists.txt | 10 +++++----- src/main.cpp | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 7504694..8c6cd60 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -37,11 +37,11 @@ if(BUILD_TESTING) target_check_warning(my_fibonacci) endif() -add_executable(my_fibonacci_main src/main.cpp) -target_link_libraries(my_fibonacci_main PUBLIC argparse my_fibonacci) -set_property(TARGET my_fibonacci_main PROPERTY CXX_STANDARD 11) +add_executable(generate_sequence src/main.cpp) +target_link_libraries(generate_sequence PUBLIC argparse my_fibonacci) +set_property(TARGET generate_sequence PROPERTY CXX_STANDARD 11) if(BUILD_TESTING) - target_check_warning(my_fibonacci_main) + target_check_warning(generate_sequence) endif() if(BUILD_TESTING) @@ -73,7 +73,7 @@ if(BUILD_TESTING) endif() install( - TARGETS my_fibonacci my_fibonacci_main + TARGETS generate_sequence my_fibonacci EXPORT my_fibonacci_targets LIBRARY DESTINATION lib RUNTIME DESTINATION bin diff --git a/src/main.cpp b/src/main.cpp index 58195ca..3a58724 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -4,7 +4,7 @@ #include int main(int argc, char** argv) { - argparse::ArgumentParser program("my_fibonacci_main"); + argparse::ArgumentParser program("generate_sequence"); program.add_description( "Generate a Fibonacci sequence up to the given number of terms."); program.add_argument("n").help("The number of terms").scan<'i', int>(); From b088236fad5504a48e28bb4bffb477a5f9901ffe Mon Sep 17 00:00:00 2001 From: Alfi Maulana Date: Sun, 17 Dec 2023 14:48:37 +0700 Subject: [PATCH 2/3] build: rename library to `sequence` --- CMakeLists.txt | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 8c6cd60..761cb86 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -24,21 +24,21 @@ cpmusepackagelock(package-lock) cpmgetpackage(argparse) cpmgetpackage(CheckWarning.cmake) -add_library(my_fibonacci src/sequence.cpp) +add_library(sequence src/sequence.cpp) target_sources( - my_fibonacci PUBLIC FILE_SET HEADERS + sequence PUBLIC FILE_SET HEADERS BASE_DIRS include FILES include/my_fibonacci/sequence.hpp ) -set_property(TARGET my_fibonacci PROPERTY CXX_STANDARD 11) +set_property(TARGET sequence PROPERTY CXX_STANDARD 11) if(BUILD_TESTING) - target_check_warning(my_fibonacci) + target_check_warning(sequence) endif() add_executable(generate_sequence src/main.cpp) -target_link_libraries(generate_sequence PUBLIC argparse my_fibonacci) +target_link_libraries(generate_sequence PUBLIC argparse sequence) set_property(TARGET generate_sequence PROPERTY CXX_STANDARD 11) if(BUILD_TESTING) target_check_warning(generate_sequence) @@ -52,15 +52,15 @@ if(BUILD_TESTING) cpmgetpackage(Catch2) include("${Catch2_SOURCE_DIR}/extras/Catch.cmake") - get_target_property(my_fibonacci_SOURCES my_fibonacci SOURCES) - add_executable(my_fibonacci_test test/sequence_test.cpp ${my_fibonacci_SOURCES}) + get_target_property(sequence_SOURCES sequence SOURCES) + add_executable(my_fibonacci_test test/sequence_test.cpp ${sequence_SOURCES}) - get_target_property(my_fibonacci_HEADER_DIRS my_fibonacci HEADER_DIRS) - get_target_property(my_fibonacci_HEADER_SET my_fibonacci HEADER_SET) + get_target_property(sequence_HEADER_DIRS sequence HEADER_DIRS) + get_target_property(sequence_HEADER_SET sequence HEADER_SET) target_sources( my_fibonacci_test PRIVATE FILE_SET HEADERS - BASE_DIRS ${my_fibonacci_HEADER_DIRS} - FILES ${my_fibonacci_HEADER_SET} + BASE_DIRS ${sequence_HEADER_DIRS} + FILES ${sequence_HEADER_SET} ) target_link_libraries(my_fibonacci_test PRIVATE Catch2::Catch2WithMain) @@ -73,7 +73,7 @@ if(BUILD_TESTING) endif() install( - TARGETS generate_sequence my_fibonacci + TARGETS generate_sequence sequence EXPORT my_fibonacci_targets LIBRARY DESTINATION lib RUNTIME DESTINATION bin From 23b3e5e629a64a5fb0946b782891eaf84e1ba5bf Mon Sep 17 00:00:00 2001 From: Alfi Maulana Date: Sun, 17 Dec 2023 14:50:39 +0700 Subject: [PATCH 3/3] build: rename test target to `sequence_test` --- CMakeLists.txt | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 761cb86..3442b9f 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -53,23 +53,23 @@ if(BUILD_TESTING) include("${Catch2_SOURCE_DIR}/extras/Catch.cmake") get_target_property(sequence_SOURCES sequence SOURCES) - add_executable(my_fibonacci_test test/sequence_test.cpp ${sequence_SOURCES}) + add_executable(sequence_test test/sequence_test.cpp ${sequence_SOURCES}) get_target_property(sequence_HEADER_DIRS sequence HEADER_DIRS) get_target_property(sequence_HEADER_SET sequence HEADER_SET) target_sources( - my_fibonacci_test PRIVATE FILE_SET HEADERS + sequence_test PRIVATE FILE_SET HEADERS BASE_DIRS ${sequence_HEADER_DIRS} FILES ${sequence_HEADER_SET} ) - target_link_libraries(my_fibonacci_test PRIVATE Catch2::Catch2WithMain) + target_link_libraries(sequence_test PRIVATE Catch2::Catch2WithMain) - target_check_warning(my_fibonacci_test) - target_compile_options(my_fibonacci_test PRIVATE --coverage -O0) - target_link_options(my_fibonacci_test PRIVATE --coverage) + target_check_warning(sequence_test) + target_compile_options(sequence_test PRIVATE --coverage -O0) + target_link_options(sequence_test PRIVATE --coverage) - catch_discover_tests(my_fibonacci_test) + catch_discover_tests(sequence_test) endif() install(