File tree Expand file tree Collapse file tree 1 file changed +7
-1
lines changed Expand file tree Collapse file tree 1 file changed +7
-1
lines changed Original file line number Diff line number Diff line change @@ -24,6 +24,7 @@ import { getAuthPromise } from './base';
2424import { TsEmbed , V1Embed } from './ts-embed' ;
2525import { addPreviewStylesIfNotPresent } from '../utils/global-styles' ;
2626import { TriggerPayload , TriggerResponse } from './hostEventClient/contracts' ;
27+ import { logger } from 'src/utils/logger' ;
2728
2829const liveboardHeightWhitelistedRoutes = [
2930 '/embed/viz/' ,
@@ -429,11 +430,16 @@ export class LiveboardEmbed extends V1Embed {
429430
430431 private defaultHeight = 500 ;
431432
432- // eslint-disable-next-line no-useless-constructor
433+
433434 constructor ( domSelector : DOMSelector , viewConfig : LiveboardViewConfig ) {
434435 viewConfig . embedComponentType = 'LiveboardEmbed' ;
435436 super ( domSelector , viewConfig ) ;
436437 if ( this . viewConfig . fullHeight === true ) {
438+ if ( this . viewConfig . vizId ) {
439+ logger . warn ( 'Full height is currently only supported for Liveboard embeds.' +
440+ 'Using full height with vizId might lead to unexpected behavior.' ) ;
441+ }
442+
437443 this . on ( EmbedEvent . RouteChange , this . setIframeHeightForNonEmbedLiveboard ) ;
438444 this . on ( EmbedEvent . EmbedHeight , this . updateIFrameHeight ) ;
439445 this . on ( EmbedEvent . EmbedIframeCenter , this . embedIframeCenter ) ;
You can’t perform that action at this time.
0 commit comments