Fix Assert.Throws Type Check (#2540)

* Fix Assert.Throws Type Check

* Update Throws.ExceptionTests.cs

* Update Throws.ExceptionTests.cs

Author: thomhurst

TUnit.Assertions.Tests/Assertions/Delegates/Throws.ExceptionTests.cs

@@ -27,7 +27,7 @@ await Assert.That(sut).ThrowsException()
         }
 
         [Test]
-        [UnconditionalSuppressMessage("Trimming", "IL2026:Members annotated with 'RequiresUnreferencedCodeAttribute' require dynamic access otherwise can break functionality when trimming application code", Justification = "<Pending>")]
+        [UnconditionalSuppressMessage("Trimming", "IL2026:Members annotated with 'RequiresUnreferencedCodeAttribute' require dynamic access otherwise can break functionality when trimming application assemblies.", Justification = "Test method.")]
         public async Task Returns_Exception_When_Awaited()
         {
             Exception exception = CreateCustomException();
@@ -49,5 +49,23 @@ public async Task Succeeds_For_Code_With_Exceptions()
 
             await Assert.That(sut).ThrowsNothing();
         }
+
+        private void ThrowsArgumentException()
+            => throw new ArgumentException("Just for testing");
+
+        [Test]
+        public async Task ThrowsAsync_DoesNotCheckType()
+        {
+            await Assert.That(async () =>
+                await Assert.ThrowsAsync<OverflowException>(LocalTestFunction)
+            ).Throws<AssertionException>();
+            return;
+
+            Task LocalTestFunction()
+            {
+                ThrowsArgumentException();
+                return Task.CompletedTask;
+            }
+        }
     }
 }

TUnit.Assertions/Assertions/Throws/ThrowsExtensions.cs

@@ -21,7 +21,7 @@ public static class ThrowsExtensions
     public static ThrowsException<object?, Exception> Throws(this IDelegateSource delegateSource, Type type, [CallerArgumentExpression("type")] string? doNotPopulateThisValue = null)
     {
         return new ThrowsException<object?, Exception>(
-            delegateSource.RegisterAssertion(new ThrowsOfTypeAssertCondition<object?, Exception>(), [doNotPopulateThisValue]),
+            delegateSource.RegisterAssertion(new ThrowsOfTypeAssertCondition(type), [doNotPopulateThisValue]),
             delegateSource,
             e => e);
     }
@@ -82,4 +82,4 @@ public static ThrowsException<TActual, TException> WithParameterName<TActual, TE
         throwsException.RegisterAssertion((selector) => new ThrowsWithParamNameAssertCondition<TActual, TException>(expected, StringComparison.Ordinal, ex => selector(ex) as ArgumentException), [doNotPopulateThisValue]);
         return throwsException;
     }
-}
+}