From 57d75e4274ba709cd5cc58695845f3d2ebcee59d Mon Sep 17 00:00:00 2001 From: Lucas Alberto Date: Mon, 22 May 2023 10:57:51 -0300 Subject: [PATCH 1/2] fix(dropdown): add type button in dropdown fix #756 --- src/lib/components/Dropdown/Dropdown.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/components/Dropdown/Dropdown.tsx b/src/lib/components/Dropdown/Dropdown.tsx index 2f759177c..8abd97709 100644 --- a/src/lib/components/Dropdown/Dropdown.tsx +++ b/src/lib/components/Dropdown/Dropdown.tsx @@ -119,11 +119,11 @@ const DropdownComponent: FC = ({ }, [ref]); return inline ? ( - ) : ( - ); From 4c0bfbc4560ea9fedd420c1e33919774d5760348 Mon Sep 17 00:00:00 2001 From: Lucas Alberto Date: Mon, 22 May 2023 11:24:24 -0300 Subject: [PATCH 2/2] test(dropdown): add test of type button in dropdown component --- src/lib/components/Dropdown/Dropdown.spec.tsx | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/src/lib/components/Dropdown/Dropdown.spec.tsx b/src/lib/components/Dropdown/Dropdown.spec.tsx index 2b17dfa08..b22f2c571 100644 --- a/src/lib/components/Dropdown/Dropdown.spec.tsx +++ b/src/lib/components/Dropdown/Dropdown.spec.tsx @@ -55,10 +55,24 @@ describe('Components / Dropdown', () => { expect(dropdown()).not.toHaveClass('invisible'); }); }); + describe('Type of button', async () => { + it('should be of type `button`', async () => { + render(); + expect(button()).toHaveAttribute('type', 'button'); + }); + + it('should be of type `button` with inline', async () => { + render(); + expect(button()).toHaveAttribute('type', 'button'); + }); + }); }); -const TestDropdown: FC<{ dismissOnClick?: boolean }> = ({ dismissOnClick = true }) => ( - +const TestDropdown: FC<{ dismissOnClick?: boolean; inline?: boolean }> = ({ + dismissOnClick = true, + inline = false, +}) => ( + Bonnie Green name@flowbite.com