Add url property to Link Node #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When applying `textlint-rule-no-dead-link` to HTML, an error occurred.
`` `console
✖ Stack trace
TypeError: Parameter "url" must be a string, not undefined
at Url.parse (url.js: 102: 11)
at Object.urlParse [as parse] (url.js: 96: 5)
at isRelative
(/usr/local/lib/node_modules/textlint-rule-no-dead-link/lib/no-dead-link
.js:83:24)
at
/usr/local/lib/node_modules/textlint-rule-no-dead-link/lib/no-dead-link.
js: 107: 11
at Generator.next (<anonymous>)
`` `
textlint-rule-no-dead-link expects the Link Node to hold the url
property, and in the case of txt, markdown it holds the actual url
property.
I think that the Link Node generated from the html file should also
keep the url property. [^ 1]
[1]: The href attribute of `a` tag is not mandatory.
If href does not exist, url is not set.
If url does not exist, a fix to ignore the target Link node is required
for `textlint-rule-no-dead-link`.
azu
reviewed
Nov 19, 2017
src/html-to-ast.js
Outdated
| node.raw = html.slice(range[0], range[1]); | ||
| } | ||
| // map `url` to Link node | ||
| if (node.type === "Link" && node.properties.href !== "undefined") { |
There was a problem hiding this comment.
node.properties.href !== "undefined"
typeof node.properties.href !== "undefined" ?
Can you add a test-case for <a>text</a> pattern?
There was a problem hiding this comment.
Thanks for the review. I'll fix it.
Fix undefined check of href, and add test for placeholder.
|
LTGM. Thanks for fixing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When applying
textlint-rule-no-dead-linkto HTML, an error occurred.`console ✖ Stack trace TypeError: Parameter "url" must be a string, not undefined at Url.parse (url.js: 102: 11) at Object.urlParse [as parse] (url.js: 96: 5) at isRelative (/usr/local/lib/node_modules/textlint-rule-no-dead-link/lib/no-dead-link .js:83:24) at /usr/local/lib/node_modules/textlint-rule-no-dead-link/lib/no-dead-link. js: 107: 11 at Generator.next (<anonymous>)`textlint-rule-no-dead-link expects the Link Node to hold the url
property, and in the case of txt, markdown it holds the actual url
property.
I think that the Link Node generated from the html file should also
keep the url property. [^ 1]
[1]: The href attribute of
atag is not mandatory.If href does not exist, url is not set.
If url does not exist, a fix to ignore the target Link node is required to
textlint-rule-no-dead-link.