Propose: allowLexeme option #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azu
reviewed
Aug 9, 2021
| { | ||
| text: "部屋の英語はroomです", | ||
| options: { | ||
| allowLexeme: false |
Member
There was a problem hiding this comment.
trueの場合は語彙素の異なる同義語を許可します
Is this allowLexeme: true?
Contributor
Author
There was a problem hiding this comment.
I wanted to test it for the case of allowLexeme=false and allowAlphabet: true. I updated the test to clarify what to be tested.
azu
reviewed
Aug 9, 2021
azu
reviewed
Aug 9, 2021
azu
reviewed
Aug 9, 2021
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an option to recognize different lexeme as the same terminology. This is not a breaking change.
For example, users can use this option for these terms: