Allowing Suites to have duplicated name so people can configure the s… #829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame suite-file to run multiple times (performance testing, resiliency, memory leak testing, etc). Did this by checking for duplicated names, and if one or more are found instead of throwing an exception we change the name to <suite name> (0), <suite name> (1), etc...
Contributor
Author
|
Oops, typo... if duplicate suite names are found the suite names are changed to "original name (0)", "original name (1)", etc so there are no internal conflicts. |
cbeust
added a commit
that referenced
this pull request
Oct 19, 2015
Allowing Suites to have duplicated name so people can configure the s…
Collaborator
|
Can you send a PR that also updates the Thanks, and thanks for the fix! |
Contributor
Author
|
Sure thing! Will send in an hour or so. Thanks for merging! 2015-10-18 21:57 GMT-05:00 Cedric Beust [email protected]:
|
juherr
added a commit
to juherr/testng
that referenced
this pull request
Oct 23, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ame suite-file to run multiple times (performance testing, resiliency, memory leak testing, etc). Did this by checking for duplicated names, and if one or more are found instead of throwing an exception we change the name to (0), (1), etc... This way they will not conflict internally in any way, results are shown properly across the board, and folks can now repeat test suites if they want to which is extremely useful to make sure you don't have timing issues, memory leaks and other problems that arise from continued use.