Skip to content

Commit 21a52ff

Browse files
author
speedythesnail
committed
Added tests and changes as requested
1 parent d7e9058 commit 21a52ff

File tree

2 files changed

+15
-2
lines changed

2 files changed

+15
-2
lines changed

testng-core/src/main/java/org/testng/internal/YamlParser.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public XmlSuite parse(String filePath, InputStream is, boolean loadClasses)
2121

2222
@Override
2323
public boolean accept(String fileName) {
24-
return Parser.hasFileScheme(fileName) && fileName.endsWith(".yaml")
25-
|| fileName.endsWith(".yml");
24+
return Parser.hasFileScheme(fileName)
25+
&& (fileName.endsWith(".yaml") || fileName.endsWith(".yml"));
2626
}
2727
}

testng-core/src/test/java/test/yaml/YamlTest.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
package test.yaml;
22

33
import static org.assertj.core.api.Assertions.assertThat;
4+
import static org.junit.jupiter.api.Assertions.assertFalse;
5+
import static org.junit.jupiter.api.Assertions.assertTrue;
46

57
import java.io.File;
68
import java.io.FileInputStream;
@@ -31,6 +33,17 @@ public Object[][] dp() {
3133
};
3234
}
3335

36+
@Test(
37+
description =
38+
"Validate that the YamlParser accepts yaml files with a .yaml or a .yml file extension, but not other file types.")
39+
public void accept() {
40+
YamlParser yamlParser = new YamlParser();
41+
42+
assertTrue(yamlParser.accept("TestSuite.yml"));
43+
assertTrue(yamlParser.accept("TestSuite.yaml"));
44+
assertFalse(yamlParser.accept("TestSuite.xml"));
45+
}
46+
3447
@Test(dataProvider = "dp")
3548
public void compareFiles(String name) throws IOException {
3649
Collection<XmlSuite> s1 =

0 commit comments

Comments
 (0)