Skip to content

fix(no-get-by-for-checking-element-not-present): false positives for negated matchers #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Fix prefer-explicit-assert raising error on destructuring statement
merged 1 commit into from
Feb 11, 2020
Merged

fix(no-get-by-for-checking-element-not-present): false positives for negated matchers #84

merged 1 commit into from
Feb 11, 2020

Conversation

@Belco90
Copy link
Member

@Belco90 Belco90 commented Feb 11, 2020

This closes #83

emmenko
emmenko approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@emmenko emmenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@Belco90 Belco90 merged commit 34da6c1 into master Feb 11, 2020
@Belco90 Belco90 deleted the fix/issue-83 branch February 11, 2020 10:18
@Belco90
Copy link
Member Author

Belco90 commented Feb 11, 2020

🎉 This PR is included in version 2.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomaslombart thomaslombart Awaiting requested review from thomaslombart

1 more reviewer

@emmenko emmenko emmenko approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rule no-get-by-for-checking-element-not-present is giving false positives

2 participants

@Belco90 @emmenko