fix: updates docs, adds tests

Author: alessbell

docs/rules/no-render-in-setup.md

@@ -2,7 +2,7 @@
 
 ## Rule Details
 
-This rule disallows the usage of `render` in setup functions (`beforeEach` and `beforeAll`) in favor of moving `render` closer to test assertions.
+This rule disallows the usage of `render` (or a custom render function) in setup functions (`beforeEach` and `beforeAll`) in favor of moving `render` closer to test assertions.
 
 Examples of **incorrect** code for this rule:
 
@@ -18,20 +18,29 @@ it('Should have foo', () => {
 it('Should have bar', () => {
   expect(screen.getByText('bar')).toBeInTheDocument();
 });
+```
+
+```js
+beforeAll(() => {
+  render(<MyComponent />);
+});
 
-it('Should have baz', () => {
-  expect(screen.getByText('baz')).toBeInTheDocument();
+it('Should have foo', () => {
+  expect(screen.getByText('foo')).toBeInTheDocument();
+});
+
+it('Should have bar', () => {
+  expect(screen.getByText('bar')).toBeInTheDocument();
 });
 ```
 
 Examples of **correct** code for this rule:
 
 ```js
-it('Should have foo, bar and baz', () => {
+it('Should have foo and bar', () => {
   render(<MyComponent />);
   expect(screen.getByText('foo')).toBeInTheDocument();
   expect(screen.getByText('bar')).toBeInTheDocument();
-  expect(screen.getByText('baz')).toBeInTheDocument();
 });
 ```
 
@@ -41,7 +50,7 @@ If you use [custom render functions](https://testing-library.com/docs/example-re
    "testing-library/no-render-in-setup": ["error", {"renderFunctions": ["renderWithRedux", "renderWithRouter"]}],
 ```
 
-If you would like to allow the use of `render` (or custom render function) in _either_ `beforeAll` or `beforeEach`, this can be configured using the option `allowTestingFrameworkSetupHook`. This may be useful if you have configured your tests to [skip auto cleanup](https://testing-library.com/docs/react-testing-library/setup#skipping-auto-cleanup). `allowTestingFrameworkSetupHook` is an enum that accepts either `"beforeAll"` or `"beforeEach"`.
+If you would like to allow the use of `render` (or a custom render function) in _either_ `beforeAll` or `beforeEach`, this can be configured using the option `allowTestingFrameworkSetupHook`. This may be useful if you have configured your tests to [skip auto cleanup](https://testing-library.com/docs/react-testing-library/setup#skipping-auto-cleanup). `allowTestingFrameworkSetupHook` is an enum that accepts either `"beforeAll"` or `"beforeEach"`.
 
 ```
    "testing-library/no-render-in-setup": ["error", {"allowTestingFrameworkSetupHook": "beforeAll"}],

lib/node-utils.ts

@@ -54,9 +54,16 @@ export function isRenderFunction(
   callNode: TSESTree.CallExpression,
   renderFunctions: string[]
 ) {
-  return ['render', ...renderFunctions].some(
-    name => isIdentifier(callNode.callee) && name === callNode.callee.name
-  );
+  // returns true for `render` and e.g. `customRenderFn`
+  // as well as `someLib.render` and `someUtils.customRenderFn`
+  return ['render', ...renderFunctions].some(name => {
+    return (
+      (isIdentifier(callNode.callee) && name === callNode.callee.name) ||
+      (isMemberExpression(callNode.callee) &&
+        isIdentifier(callNode.callee.property) &&
+        name === callNode.callee.property.name)
+    );
+  });
 }
 
 export function isObjectPattern(

tests/lib/rules/no-render-in-setup.test.ts

@@ -17,13 +17,11 @@ ruleTester.run(RULE_NAME, rule, {
         })
       `,
     },
+    // test config options
     ...TESTING_FRAMEWORK_SETUP_HOOKS.map(setupHook => ({
       code: `
         ${setupHook}(() => {
-          const wrapper = () => {
-            renderWithRedux(<Component/>)
-          }
-          wrapper();
+          renderWithRedux(<Component/>)
         })
       `,
       options: [
@@ -33,6 +31,14 @@ ruleTester.run(RULE_NAME, rule, {
         },
       ],
     })),
+    // // test usage of a non-Testing Library render fn
+    // ...TESTING_FRAMEWORK_SETUP_HOOKS.map(setupHook => ({
+    //   code: `import { render } from 'imNoTestingLibrary';
+
+    //   ${setupHook}(() => {
+    //     render(<Component/>)
+    //   })`,
+    // })),
   ],
 
   invalid: [
@@ -85,7 +91,7 @@ ruleTester.run(RULE_NAME, rule, {
           const wrapper = () => {
             render(<Component/>)
           }
-          wrapper();
+          wrapper()
         })
       `,
       errors: [
@@ -101,10 +107,7 @@ ruleTester.run(RULE_NAME, rule, {
       return {
         code: `
         ${disallowedHook}(() => {
-          const wrapper = () => {
-            render(<Component/>)
-          }
-          wrapper();
+          render(<Component/>)
         })
       `,
         options: [
@@ -119,5 +122,52 @@ ruleTester.run(RULE_NAME, rule, {
         ],
       };
     }),
+    ...TESTING_FRAMEWORK_SETUP_HOOKS.map(setupHook => ({
+      code: `import { render } from '@testing-library/foo';
+
+      ${setupHook}(() => {
+        render(<Component/>)
+      })`,
+      errors: [
+        {
+          messageId: 'noRenderInSetup',
+        },
+      ],
+    })),
+    ...TESTING_FRAMEWORK_SETUP_HOOKS.map(setupHook => ({
+      code: `import * as testingLibrary from '@testing-library/foo';
+
+      ${setupHook}(() => {
+        testingLibrary.render(<Component/>)
+      })`,
+      errors: [
+        {
+          messageId: 'noRenderInSetup',
+        },
+      ],
+    })),
+    ...TESTING_FRAMEWORK_SETUP_HOOKS.map(setupHook => ({
+      code: `import { render } from 'imNoTestingLibrary';
+      import * as testUtils from '../utils';
+
+      ${setupHook}(() => {
+        testUtils.renderWithRedux(<Component/>)
+      })
+
+      it('Test', () => {
+        render(<Component/>)
+      })
+      `,
+      options: [
+        {
+          renderFunctions: ['renderWithRedux'],
+        },
+      ],
+      errors: [
+        {
+          messageId: 'noRenderInSetup',
+        },
+      ],
+    })),
   ],
 });