FoundationDB as the state store driver #1845
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try to move everything an async interface. Remove migrations.
RocksDB transactions are not Send, and we cannot send them across threads. So, we cannot have a enum holding both.
Contributor
Author
|
This PR is not necessary anymore. The relevant logic here lives now in #1856. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We want to move away from RocksDB as the state store driver.
What
This is a very early implementation of the state store driver using FoundationDB. There are still many things that don't work. I'm opening it to keep track of this work outside my laptop.
I had to remove the whole migrations module, as welll as the RocksDB implementation to move things forward. I tried keeping both drivers, but dealing with lifetimes for RocksDB transactions and FDB transactions became a major pita.
Testing
The code compiles with multiple warnings at the moment. Tests fail since there is no FDB server running in CI.
Contribution Checklist
make fmtin the package directory.make fmtinserver/.