PipelineRun enters cancelled state even if cancelling TaskRuns fails

Expected Behavior

Cancelling a PipelineRun should not succeed if the TaskRuns it created were not able to be cancelled.

Actual Behavior

In our PipelineRun cancellation code we immediately set the status of a PipelineRun to cancelled regardless of whether the TaskRuns it created were able to be cancelled.

This seems counter-intuitive and like a potential source of confusion for users. If TaskRuns couldn't be cancelled then that should probably be stored as some kind of error or event on the PipelineRun and the PipelineRun itself should remain in an un-cancelled state to indicate that there are still running processes related to it.

[bobcatfish]

/assign jerop

[tekton-robot]

@bobcatfish: GitHub didn't allow me to assign the following users: jerop.

Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign jerop

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bobcatfish]

🤔

[jerop]

✋

[bobcatfish]

/assign jerop

[vdemeester]

I ran the task manually to update members of the org 👼 We had.. a small issue on it 😝